From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: davidastro <davidastro@hotmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Fix for __div64_32 locks when using some 64 bit numbers
Date: Wed, 18 Mar 2009 10:03:04 +1100 [thread overview]
Message-ID: <1237330984.25062.164.camel@pasglop> (raw)
In-Reply-To: <22567864.post@talk.nabble.com>
On Tue, 2009-03-17 at 14:15 -0700, davidastro wrote:
> I found a bug when using the function __div64_32 in assembly in a 32 bit ppc
> architecture unit.
>
> I tried the numbers 55834565048000000 for the dividend and 4294967079 for
> the divisor. When passing these two numbers to the function __div64_32, I
> had a software lock. I searched for possible patches online and in different
> forums but I could not find anything related to the assembly implementation
> to this function (I would have to apologize if somebody already found a fix
> :-) ).
>
> Anyway, when analyzing the assembly code, I found out with gdb the problem.
> I am not an expert in ppc architecture but I read the documentation and I am
> pretty sure I solved the issue (I have been testing for couple of days using
> random 64 to 32 number combinations with good results).
>
> Who or Where should I post the fix to be reviewed.
Here is fine :-)
Ben.
next prev parent reply other threads:[~2009-03-17 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 21:15 Fix for __div64_32 locks when using some 64 bit numbers davidastro
2009-03-17 23:03 ` Benjamin Herrenschmidt [this message]
2009-03-18 15:33 ` davidastro
2009-03-23 4:39 ` Paul Mackerras
2009-03-23 17:56 ` davidastro
2009-03-20 19:33 ` davidastro
2009-03-21 21:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237330984.25062.164.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davidastro@hotmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.