From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LkSTo-0000yO-36 for qemu-devel@nongnu.org; Thu, 19 Mar 2009 20:20:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LkSTi-0000yC-Hv for qemu-devel@nongnu.org; Thu, 19 Mar 2009 20:20:54 -0400 Received: from [199.232.76.173] (port=52547 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LkSTi-0000y9-B3 for qemu-devel@nongnu.org; Thu, 19 Mar 2009 20:20:50 -0400 Received: from phong.sigbus.net ([65.49.35.42]:45443) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LkSTh-0002bU-VP for qemu-devel@nongnu.org; Thu, 19 Mar 2009 20:20:50 -0400 Received: from [192.168.0.3] (c-71-202-202-194.hsd1.ca.comcast.net [71.202.202.194]) by phong.sigbus.net (Postfix) with ESMTPSA id D294B95C06C for ; Thu, 19 Mar 2009 17:20:43 -0700 (PDT) From: Nolan Content-Type: text/plain Date: Thu, 19 Mar 2009 17:20:43 -0700 Message-Id: <1237508443.15350.149.camel@voxel> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] oom_check qemu_memalign Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" As suggested by Avi on the KVM list, this patch adds oom_check to qemu_memalign, in the interests of symmetry with qemu_malloc*. See also: http://article.gmane.org/gmane.comp.emulators.kvm.devel/29510 Signed-off-by: Nolan Leake sigbus.net> Index: qemu-malloc.c =================================================================== --- qemu-malloc.c (revision 6858) +++ qemu-malloc.c (working copy) @@ -24,7 +24,7 @@ #include "qemu-common.h" #include -static void *oom_check(void *ptr) +void *qemu_oom_check(void *ptr) { if (ptr == NULL) abort(); @@ -43,13 +43,13 @@ void *qemu_malloc(size_t size) { - return oom_check(malloc(size)); + return qemu_oom_check(malloc(size)); } void *qemu_realloc(void *ptr, size_t size) { if (size) - return oom_check(realloc(ptr, size)); + return qemu_oom_check(realloc(ptr, size)); else return realloc(ptr, size); } Index: qemu-common.h =================================================================== --- qemu-common.h (revision 6858) +++ qemu-common.h (working copy) @@ -126,6 +126,7 @@ #define qemu_isascii(c) isascii((unsigned char)(c)) #define qemu_toascii(c) toascii((unsigned char)(c)) +void *qemu_oom_check(void *ptr); void *qemu_malloc(size_t size); void *qemu_realloc(void *ptr, size_t size); void *qemu_mallocz(size_t size); Index: osdep.c =================================================================== --- osdep.c (revision 6858) +++ osdep.c (working copy) @@ -186,11 +186,11 @@ ret = posix_memalign(&ptr, alignment, size); if (ret != 0) return NULL; - return ptr; + return qemu_oom_check(ptr); #elif defined(HOST_BSD) - return valloc(size); + return qemu_oom_check(valloc(size)); #else - return memalign(alignment, size); + return qemu_oom_check(memalign(alignment, size)); #endif }