From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC v14-rc][PATCH 14/23] A new file type (CR_FD_OBJREF) for a file descriptor already setup Date: Fri, 20 Mar 2009 13:27:26 -0700 Message-ID: <1237580846.8286.254.camel@nimitz> References: <1237574868-3371-1-git-send-email-orenl@cs.columbia.edu> <1237574868-3371-15-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1237574868-3371-15-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Pasting from the applied patches: > /* cr_write_file - dump the state of a given file pointer */ > int cr_write_file(struct cr_ctx *ctx, struct file *file) > { > struct cr_hdr h; > struct cr_hdr_file *hh; > struct inode *inode = file->f_dentry->d_inode; > enum fd_type fd_type; > int new = 0; /* pacitfy gcc */ > int ret; > > h.type = CR_HDR_FILE; > h.len = sizeof(*hh); > > hh = cr_hbuf_get(ctx, sizeof(*hh)); > if (!hh) > return -ENOMEM; > > hh->f_flags = file->f_flags; > hh->f_mode = file->f_mode; > hh->f_pos = file->f_pos; > hh->f_version = file->f_version; > /* FIX: need also file->uid, file->gid, file->f_owner, etc */ > > fd_type = cr_inode_to_fdtype(inode); > if (fd_type < 0) { > cr_hbuf_put(ctx, sizeof(*hh)); > return fd_type; > } > > hh->fd_objref = cr_inode_to_objref(ctx, inode, hh->fd_type, &new); > pr_debug("type %d objref %d (%d)\n", hh->fd_type, hh->fd_objref, new); > if (!new) > fd_type = CR_FD_OBJREF; Where does 'hh->fd_type' get initialized? Did you mean just plain 'fd_type'? -- Dave