All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [RFC v14-rc][PATCH 17/23] Record 'struct file' object instead of the file name for VMAs
Date: Fri, 20 Mar 2009 15:43:47 -0700	[thread overview]
Message-ID: <1237589027.8286.340.camel@nimitz> (raw)
In-Reply-To: <49C41273.5000202-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

On Fri, 2009-03-20 at 18:02 -0400, Oren Laadan wrote:
> Anyway, the down side that I was hoping to avoid on restart, is to need
> to expect "either...or" values of 'struct cr_hdr'->type instead of a
> single deterministic value. That's the extra burden that I was referring
> to.

I think this "determinism" actually adds a ton of complexity to the
code.  It forces us to open-code the entire format. 

Here's what I would suggest: at any point during restore, we should be
able to read two kinds of objects:

	1. the next expected "deterministic" object
	2. something to go into the objhash

We can encapsulate the objhash object reads inside of the normal
cr_read_obj() calls.  If they see the object that we're looking for then
we return that.  If we see an objhash object, then we put it in the
objhash and retry.  

-- Dave

  parent reply	other threads:[~2009-03-20 22:43 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20 18:47 [RFC v14-rc1][PATCH 00/23] Kernel based checkpoint/restart Oren Laadan
     [not found] ` <1237574868-3371-1-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 18:47   ` [RFC v14-rc][PATCH 01/23] Create syscalls: sys_checkpoint, sys_restart Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 02/23] Checkpoint/restart: initial documentation Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 03/23] Make file_pos_read/write() public Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 04/23] General infrastructure for checkpoint restart Oren Laadan
     [not found]     ` <1237574868-3371-5-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:24       ` Serge E. Hallyn
     [not found]         ` <20090320212400.GA15946-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-20 21:34           ` Oren Laadan
     [not found]             ` <49C40BDC.7050304-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:42               ` Serge E. Hallyn
2009-03-20 18:47   ` [RFC v14-rc][PATCH 05/23] x86 support for checkpoint/restart Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 06/23] Dump memory address space Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 07/23] Restore " Oren Laadan
     [not found]     ` <1237574868-3371-8-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 23:54       ` Serge E. Hallyn
     [not found]         ` <20090320235433.GA19565-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-22 21:51           ` Oren Laadan
     [not found]             ` <49C6B2F6.6080304-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-23 15:01               ` Serge E. Hallyn
2009-03-20 18:47   ` [RFC v14-rc][PATCH 08/23] Infrastructure for shared objects Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 09/23] Dump open file descriptors Oren Laadan
     [not found]     ` <1237574868-3371-10-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 20:09       ` Dave Hansen
2009-03-20 20:55         ` Oren Laadan
     [not found]           ` <49C402BE.4010308-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:14             ` Dave Hansen
2009-03-24 15:24               ` Serge E. Hallyn
     [not found]                 ` <20090324152442.GA18066-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-24 15:37                   ` Oren Laadan
     [not found]                     ` <49C8FE39.6040605-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-24 15:44                       ` Serge E. Hallyn
2009-03-20 18:47   ` [RFC v14-rc][PATCH 10/23] Restore " Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 11/23] External checkpoint of a task other than ourself Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 12/23] Checkpoint multiple processes Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 13/23] Restart " Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 14/23] A new file type (CR_FD_OBJREF) for a file descriptor already setup Oren Laadan
     [not found]     ` <1237574868-3371-15-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 20:11       ` Dave Hansen
2009-03-20 21:02         ` Oren Laadan
2009-03-20 20:14       ` Dave Hansen
2009-03-20 20:27       ` Dave Hansen
2009-03-20 21:01         ` Oren Laadan
     [not found]           ` <49C40447.3070604-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:14             ` Dave Hansen
2009-03-20 20:46       ` Dave Hansen
2009-03-20 18:47   ` [RFC v14-rc][PATCH 15/23] Checkpoint open pipes Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 16/23] Restore " Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 17/23] Record 'struct file' object instead of the file name for VMAs Oren Laadan
     [not found]     ` <1237574868-3371-18-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 20:57       ` Dave Hansen
2009-03-20 21:20         ` Oren Laadan
     [not found]           ` <49C40893.1060602-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:30             ` Dave Hansen
2009-03-20 22:02               ` Oren Laadan
     [not found]                 ` <49C41273.5000202-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 22:43                   ` Dave Hansen [this message]
2009-03-20 18:47   ` [RFC v14-rc][PATCH 18/23] Prepare to support shared memory Oren Laadan
     [not found]     ` <1237574868-3371-19-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:27       ` Dave Hansen
2009-03-27  2:31         ` Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 19/23] Dump anonymous- and file-mapped- " Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 20/23] Restore " Oren Laadan
     [not found]     ` <1237574868-3371-21-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-20 21:42       ` Dave Hansen
2009-03-20 18:47   ` [RFC v14-rc][PATCH 21/23] s390: Expose a constant for the number of words representing the CRs Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 22/23] c/r: Add CR_COPY() macro (v4) Oren Laadan
     [not found]     ` <1237574868-3371-23-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2009-03-24 15:11       ` Serge E. Hallyn
     [not found]         ` <20090324151139.GA17589-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-03-27  2:19           ` Oren Laadan
2009-03-20 18:47   ` [RFC v14-rc][PATCH 23/23] s390: define s390-specific checkpoint-restart code (v7) Oren Laadan
2009-03-23 22:18   ` [RFC v14-rc1][PATCH 00/23] Kernel based checkpoint/restart Nathan Lynch
     [not found]     ` <20090323171818.4c238e9d-4v5LP+xe+1byhTdZtsIeww@public.gmane.org>
2009-03-23 23:35       ` Oren Laadan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1237589027.8286.340.camel@nimitz \
    --to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.