From: Matt Mackall <mpm@selenic.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Keiichi Kii <k-keiichi@bx.jp.nec.com>,
stable@kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] netconsole: fix BUG during net device "upping"
Date: Sun, 22 Mar 2009 20:20:58 -0500 [thread overview]
Message-ID: <1237771258.4231.134.camel@calx> (raw)
In-Reply-To: <49C61AAA.8050507@gmail.com>
On Sun, 2009-03-22 at 12:02 +0100, Marcin Slusarz wrote:
> When ndo_open (eg skge_up) function printks something, netconsole decides
> it can use this device because it checks state only (netif_running) which is
> set before ndo_open. Check device flags too.
That's fairly unfortunate semantics for netif_running. But if Dave
agrees that it's reasonable for that to be set to true at this point in
time, then I guess we'll go with it.
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2009-03-23 1:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 11:02 [PATCH] netconsole: fix BUG during net device "upping" Marcin Slusarz
2009-03-23 1:20 ` Matt Mackall [this message]
2009-03-23 4:21 ` David Miller
2009-03-23 8:04 ` Jarek Poplawski
2009-03-23 8:05 ` David Miller
2009-03-23 8:11 ` Jarek Poplawski
2009-03-23 8:15 ` David Miller
2009-03-23 9:20 ` Jarek Poplawski
2009-03-24 8:22 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1237771258.4231.134.camel@calx \
--to=mpm@selenic.com \
--cc=davem@davemloft.net \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.