Re: [PATCH 5/5] ar9170: update Makefile, Kconfig and MAINTAINERS

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Tue, 2009-03-24 at 01:26 +0100, Christian Lamparter wrote:

> Shh, there's a secret plan, see ar9170/main.c
> 
> /*
>  * BIG FAT TODO:
>  *
>  * By the looks of things: these devices share a lot of things like
>  * EEPROM layout/design and PHY code with other Atheros WIFI products.
>  * So this driver/library will eventually become ath9k code... or vice versa ;-)
>  */
> 
> And the ath5k<->ath9k merge could provide some "helper" function for this
> driver as well... (wishful thinking, but anyway...)

_Very_ wishful thinking -- only very small parts of the design are
really shared, the PHY stuff, which happens to be relevant to the
eeprom.

> Meanwhile, what about a config option that can be enabled to
> integrate everything into the front-end module (ar9170usb)?
> ( However, I don't think this config solution will stand a chance ;-) 
>   and we all come to the same "all-in-one works best" conclusion.  )

This seems like a pointless option. Why not just change the Kconfig file
to remove the common option and link both files into one binary,
removing all EXPORT_SYMBOLs?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]