From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
dmitri.vorobiev@movial.com
Subject: Re: [PATCH] module: Kill warning: label 'free_init' defined but not used
Date: Thu, 26 Mar 2009 01:24:45 +0530 [thread overview]
Message-ID: <1238010885.2500.65.camel@ht.satnam> (raw)
In-Reply-To: <Pine.LNX.4.64.0903252041190.14101@anakin>
On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote:
> On m68k (which doesn't do SMP), I get:
>
> | kernel/module.c:2291: warning: label 'free_init' defined but not used
>
> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848
> ("module: fix refptr allocation and release order").
> Move the label inside the #ifdef, as the goto is protected by the same #ifdef.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
AFAIK, it is already fixed in -tip:
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7
--
JSR
next prev parent reply other threads:[~2009-03-25 19:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 19:43 [PATCH] module: Kill warning: label 'free_init' defined but not used Geert Uytterhoeven
2009-03-25 19:54 ` Jaswinder Singh Rajput [this message]
2009-03-25 20:05 ` Geert Uytterhoeven
2009-03-25 20:22 ` Jaswinder Singh Rajput
2009-03-25 22:52 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238010885.2500.65.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=dmitri.vorobiev@movial.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.