From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH -tip] x86: unification of cpu/bugs.c
Date: Thu, 26 Mar 2009 19:59:54 +0530 [thread overview]
Message-ID: <1238077794.2507.7.camel@ht.satnam> (raw)
In-Reply-To: <20090326141228.GT7030@erda.amd.com>
On Thu, 2009-03-26 at 15:12 +0100, Robert Richter wrote:
> > +/*
> > + * Check various bugs
> > + */
> > +static void __init check_various_bugs(void)
> > +{
> > + check_config();
> > + check_fpu();
> > + check_hlt();
> > + check_popad();
> > +
This is applicable to 32 bit only. right ?
> > + init_utsname()->machine[1] =
> > + '0' + (boot_cpu_data.x86 > 6 ? 6 : boot_cpu_data.x86);
>
hmm. this can be common.
> Did you evaluate why these functions are 32 bit only? Same applies to
> 64 bit below. It seems this is not a unification and instead only some
> move-around of code.
>
Thanks for pointing.
--
JSR
prev parent reply other threads:[~2009-03-26 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 12:02 [PATCH -tip] x86: unification of cpu/bugs.c Jaswinder Singh Rajput
2009-03-26 13:12 ` Robert Richter
2009-03-26 13:42 ` Jaswinder Singh Rajput
2009-03-26 14:12 ` Robert Richter
2009-03-26 14:29 ` Jaswinder Singh Rajput [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238077794.2507.7.camel@ht.satnam \
--to=jaswinder@kernel.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.