From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH 0/2] qemu: SMBIOS passing support Date: Mon, 30 Mar 2009 09:40:33 -0600 Message-ID: <1238427633.15558.172.camel@lappy> References: <1237835133.7276.1107.camel@lappy> <1238421576.15558.146.camel@lappy> <20090330143845.GA26602@redhat.com> <49D0DE68.60309@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "Daniel P. Berrange" , qemu-devel , kvm To: Avi Kivity Return-path: Received: from g4t0016.houston.hp.com ([15.201.24.19]:28043 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbZC3Pku (ORCPT ); Mon, 30 Mar 2009 11:40:50 -0400 In-Reply-To: <49D0DE68.60309@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2009-03-30 at 17:59 +0300, Avi Kivity wrote: > Daniel P. Berrange wrote: > > I can't help thinking that if we wish to provide metadata to guest OS > > like system model, serial number, etc, then we'd be better off using > > explicit named flags (or QEMU config file settings once that exists) > > > > -system-serial 2141241521 -system-model "Some Virtual Machine" > > > > and have QEMU generate the neccessary SMBIOS data, or other equivalent > > data tables to suit the non-PC based machine types for which SMBIOS > > is not relevant. > > > > -smbios serial=blah,model=bleach ? > Unfortunately that does make them smbios specific, while I think Daniel is pointing out that several options may be useful on other platforms. This is basically the same issue we have with -uuid already. -uuid is a non-smbios specific option, but rombios will incorporate the data when it builds the type 1 entry. I've retained this functionality, so that a -uuid option will override the uuid in a passed in type 1 entry. This could be further extended with separate patches to provide serial or model numbers generically, but allow them to override smbios values. This seems complimentary to the patches in this series, but I don't think it replaces all the functionality we get from a raw smbios entry interface. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoJbb-0007xx-Vc for qemu-devel@nongnu.org; Mon, 30 Mar 2009 11:40:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoJbX-0007rz-99 for qemu-devel@nongnu.org; Mon, 30 Mar 2009 11:40:55 -0400 Received: from [199.232.76.173] (port=33536 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoJbW-0007rO-UG for qemu-devel@nongnu.org; Mon, 30 Mar 2009 11:40:51 -0400 Received: from g4t0016.houston.hp.com ([15.201.24.19]:28044) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LoJbW-0007cw-8A for qemu-devel@nongnu.org; Mon, 30 Mar 2009 11:40:50 -0400 From: Alex Williamson In-Reply-To: <49D0DE68.60309@redhat.com> References: <1237835133.7276.1107.camel@lappy> <1238421576.15558.146.camel@lappy> <20090330143845.GA26602@redhat.com> <49D0DE68.60309@redhat.com> Content-Type: text/plain Date: Mon, 30 Mar 2009 09:40:33 -0600 Message-Id: <1238427633.15558.172.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/2] qemu: SMBIOS passing support Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel , kvm On Mon, 2009-03-30 at 17:59 +0300, Avi Kivity wrote: > Daniel P. Berrange wrote: > > I can't help thinking that if we wish to provide metadata to guest OS > > like system model, serial number, etc, then we'd be better off using > > explicit named flags (or QEMU config file settings once that exists) > > > > -system-serial 2141241521 -system-model "Some Virtual Machine" > > > > and have QEMU generate the neccessary SMBIOS data, or other equivalent > > data tables to suit the non-PC based machine types for which SMBIOS > > is not relevant. > > > > -smbios serial=blah,model=bleach ? > Unfortunately that does make them smbios specific, while I think Daniel is pointing out that several options may be useful on other platforms. This is basically the same issue we have with -uuid already. -uuid is a non-smbios specific option, but rombios will incorporate the data when it builds the type 1 entry. I've retained this functionality, so that a -uuid option will override the uuid in a passed in type 1 entry. This could be further extended with separate patches to provide serial or model numbers generically, but allow them to override smbios values. This seems complimentary to the patches in this series, but I don't think it replaces all the functionality we get from a raw smbios entry interface. Thanks, Alex