From: "Michel Dänzer" <michel@daenzer.net>
To: "Robert T. Drury" <rtdrury@earthlink.net>
Cc: benh@kernel.crashing.org, akpm@linux-foundation.org,
linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] resend: radeon backlight shutoff flashes momentarily
Date: Wed, 01 Apr 2009 13:21:05 +0200 [thread overview]
Message-ID: <1238584865.7828.9462.camel@thor.local> (raw)
In-Reply-To: <49D3339A.8070603@earthlink.net>
On Wed, 2009-04-01 at 02:27 -0700, Robert T. Drury wrote:
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12845
>
> Aluminum Powerbook G4 with Radeon 9600:
>
> The backlight momentarily flashes brightly when turning off. If the
> backlight is originally dim, the flash is more noticeable. This momentary
> flash is stressful on the power circuit.
>
> This patch removes the & ~LVDS_BL_MOD_EN above the first OUTREG to
> LVDS_GEN_CNTL to eliminate the flash on shutoff, only for powerbook5,3
> and CHIP_FAMILY_RV350.
As you're checking for a specific Apple laptop model, there's no need to
check the chip family as well.
(As mentioned before, I'm seeing the flash on a PowerBook5,8 as well,
but I haven't got around to trying the patch, will do when I get time)
--
Earthling Michel Dänzer | http://www.vmware.com
Libre software enthusiast | Debian, X and DRI developer
------------------------------------------------------------------------------
_______________________________________________
Linux-fbdev-devel mailing list
Linux-fbdev-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-fbdev-devel
next prev parent reply other threads:[~2009-04-01 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-01 9:27 [PATCH] resend: radeon backlight shutoff flashes momentarily Robert T. Drury
2009-04-01 11:21 ` Michel Dänzer [this message]
2009-04-06 14:41 ` Michel Dänzer
2009-04-10 8:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1238584865.7828.9462.camel@thor.local \
--to=michel@daenzer.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rtdrury@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.