From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kieran Mansley <kmansley@solarflare.com>
Subject: Re: [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
Date: Thu, 02 Apr 2009 09:13:03 +0100
Message-ID: <1238659983.4271.6.camel@moonstone.uk.level5networks.com>
References: <C5F90122.5516%keir.fraser@eu.citrix.com>
	<1238583605.4440.33.camel@moonstone.uk.level5networks.com>
	<20090401183929.GA7721@kremvax.cs.ubc.ca>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090401183929.GA7721@kremvax.cs.ubc.ca>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Brendan Cully <brendan@cs.ubc.ca>
Cc: "andy@cs.ubc.ca" <andy@cs.ubc.ca>, xen-devel@lists.xensource.com, keir.fraser@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2009-04-01 at 11:39 -0700, Brendan Cully wrote:
> I'm afraid my memory of the kernel suspend mechanics has gotten a bit
> rusty over the last few months, so I may be off-base here. But I
> thought that xs_suspend masked watches until xs_reusume or
> xs_suspend_cancel? If that is the case, isn't that on its own enough
> to protect netfront?

If that's the case, it should be enough, yes.

Do watches that would have fired during that time fire at the end of
masked period?  If not, we'd still have to access xenstore on suspend
cancel to check if we've missed a change.

Kieran