From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757424AbZDDHLt (ORCPT ); Sat, 4 Apr 2009 03:11:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754313AbZDDHLi (ORCPT ); Sat, 4 Apr 2009 03:11:38 -0400 Received: from hera.kernel.org ([140.211.167.34]:49325 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbZDDHLi (ORCPT ); Sat, 4 Apr 2009 03:11:38 -0400 Subject: Re: [PATCH] x86: make mtrr code could use debugpat From: Jaswinder Singh Rajput To: Ingo Molnar Cc: Linus Torvalds , Yinghai Lu , "Pallipadi, Venkatesh" , "Siddha, Suresh B" , Arjan van de Ven , Thomas Gleixner , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , Andrew Morton In-Reply-To: <1238827929.4068.9.camel@ht.satnam> References: <1238434120.4529.783.camel@localhost.localdomain> <20090403175555.GH6295@elte.hu> <20090403212152.GA3493@linux-os.sc.intel.com> <20090403222928.GA6446@elte.hu> <49D68F4B.9010808@kernel.org> <20090404011805.GA19492@elte.hu> <1238827929.4068.9.camel@ht.satnam> Content-Type: text/plain Date: Sat, 04 Apr 2009 12:39:46 +0530 Message-Id: <1238828986.4068.18.camel@ht.satnam> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2009-04-04 at 12:22 +0530, Jaswinder Singh Rajput wrote: > On Sat, 2009-04-04 at 03:18 +0200, Ingo Molnar wrote: > > * Linus Torvalds wrote: > > > > > On Fri, 3 Apr 2009, Yinghai Lu wrote: > > > > > > > > only print out get_mtrr when debugpat > > > > > > Is that get_mtrr message really so interesting that it needs to be > > > printed out at all? Even with debugpat? > > > > With debugpat it's probably interesting - i think only a very small > > fraction of users will enable it, and if they do we really want to > > track all MTRR state. > > > > Since old MTRR state gets destroyed by new settings we better have a > > clear idea how the BIOS set it, that might give us clues about > > quirks, etc. > > > > Based on MTRR bugreport patterns i was the one who asked Yinghai > > during the development cycle to add more debugging there - so i'm to > > blame for those printouts. We had several cases where it would have > > been useful had we known the precise history of MTRR settings. > > > > I was under the impression that KERN_DEBUG would only show up on the > > console if 'debug' is passed in on the boot command line - but your > > bootlog didnt have 'debug' in it and i guess having it so frequently > > in the dmesg is confusing as well. It might even be there for every > > Xorg startup. > > > > If you still want to debug it, use some special parameters at command > line to avoid annoyance to others. > > These debug messages really screwed up my life from last month. > If you surprise how these debug messages screwed up my life, so here is some clues: 1. I pointed to remove or suppress these messages and Ingo, Andrew and then later on Thomas become upset with me. 2. And because of their upset, I need to delete more than 100 of my patches and delete many development trees in last few weeks. -- JSR