From: Michael Ellerman <michael@ellerman.id.au>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Print information about mapping hw irqs to virtual irqs
Date: Mon, 06 Apr 2009 22:57:22 +1000 [thread overview]
Message-ID: <1239022642.6643.2.camel@localhost> (raw)
In-Reply-To: <20090406123001.GA3044@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On Mon, 2009-04-06 at 14:30 +0200, Wolfram Sang wrote:
> On Mon, Apr 06, 2009 at 12:05:02PM +1000, Michael Ellerman wrote:
> > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> > index 5576147..8c1a496 100644
> > --- a/arch/powerpc/kernel/irq.c
> > +++ b/arch/powerpc/kernel/irq.c
> > @@ -672,11 +672,13 @@ unsigned int irq_create_mapping(struct irq_host *host,
> > return NO_IRQ;
> > }
> > }
> > - pr_debug("irq: -> obtained virq %d\n", virq);
> >
> > if (irq_setup_virq(host, virq, hwirq))
> > return NO_IRQ;
> >
> > + printk(KERN_DEBUG "irq: irq %lu on host %s mapped to virtual irq %u\n",
> > + hwirq, host->of_node ? host->of_node->full_name : "null", virq);
> > +
>
> Are you replacing the pr_debug because you want to drop the
> DEBUG-dependency?
Yes. Several people have been confused by the value in /proc/interrupts
not matching what they expected - so I want there to be something in
dmesg by default that will hopefully make it clear to people what's
going on.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-04-06 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 2:05 [PATCH] powerpc: Print information about mapping hw irqs to virtual irqs Michael Ellerman
2009-04-06 12:30 ` Wolfram Sang
2009-04-06 12:57 ` Michael Ellerman [this message]
2009-04-06 13:27 ` Grant Likely
2009-04-06 13:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239022642.6643.2.camel@localhost \
--to=michael@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.