From: Steven Rostedt <srostedt@redhat.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/2] powerpc/ftrace: Fix printf format warning
Date: Mon, 06 Apr 2009 10:46:17 -0400 [thread overview]
Message-ID: <1239029177.4753.4.camel@localhost.localdomain> (raw)
In-Reply-To: <e74b6f429f71479547bbae5871cdc87b7c6b78b5.1239028836.git.michael@ellerman.id.au>
On Tue, 2009-04-07 at 00:40 +1000, Michael Ellerman wrote:
> 'tramp' is an unsigned long, so print it with %lx.
>
> Fixes the following build warning:
> arch/powerpc/kernel/ftrace.c:291: error: format ‘%x’ expects type ‘unsigned int’, but argument 2 has type ‘long unsigned int’
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
> arch/powerpc/kernel/ftrace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
> index e9d9d38..e1edf5a 100644
> --- a/arch/powerpc/kernel/ftrace.c
> +++ b/arch/powerpc/kernel/ftrace.c
> @@ -288,7 +288,7 @@ __ftrace_make_nop(struct module *mod,
> if (tramp & 0x8000)
> tramp -= 0x10000;
>
> - pr_debug(" %x ", tramp);
> + pr_debug(" %lx ", tramp);
>
> if (tramp != addr) {
> printk(KERN_ERR
next prev parent reply other threads:[~2009-04-06 14:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 14:40 [PATCH 1/2] powerpc/ftrace: Fix #if that should be #ifdef Michael Ellerman
2009-04-06 14:40 ` [PATCH 2/2] powerpc/ftrace: Fix printf format warning Michael Ellerman
2009-04-06 14:46 ` Steven Rostedt [this message]
2009-04-06 14:45 ` [PATCH 1/2] powerpc/ftrace: Fix #if that should be #ifdef Steven Rostedt
2009-04-06 14:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239029177.4753.4.camel@localhost.localdomain \
--to=srostedt@redhat.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.