From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LrJPC-0006dr-5a for mharc-grub-devel@gnu.org; Tue, 07 Apr 2009 18:04:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LrJP9-0006ce-Uu for grub-devel@gnu.org; Tue, 07 Apr 2009 18:04:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LrJP4-0006Zj-V9 for grub-devel@gnu.org; Tue, 07 Apr 2009 18:04:27 -0400 Received: from [199.232.76.173] (port=40741 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LrJP4-0006Zg-OE for grub-devel@gnu.org; Tue, 07 Apr 2009 18:04:22 -0400 Received: from c60.cesmail.net ([216.154.195.49]:33569) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LrJP4-0004rN-9n for grub-devel@gnu.org; Tue, 07 Apr 2009 18:04:22 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 07 Apr 2009 18:04:21 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 8B8EF34C6D for ; Tue, 7 Apr 2009 18:05:33 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <49DB016D.1070000@gmail.com> References: <1239032043.8986.27.camel@mj> <200904070931.09559.okuji@enbug.org> <1239065374.15621.202.camel@mj> <49DB016D.1070000@gmail.com> Content-Type: text/plain Date: Tue, 07 Apr 2009 18:04:18 -0400 Message-Id: <1239141858.6810.15.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Video mode fixes in linux loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 22:04:28 -0000 On Tue, 2009-04-07 at 09:31 +0200, phcoder wrote: > Does it actually work? No. But at least it loads the kernel. > I don't see the code which either handles > GRUB_LINUX_VID_MODE_ASK or passes it to the kernel. We could set params->vid_mode, but the mode setting in the kernel is done in the 16-bit code that we don't use. > Also it looks like > vga= parameter is parsed by grub and grub passes only video mode values > as resolution and color depth. Wouldn't it be better to move to a more > modern video mode specification method? As gfxpayload variable > previously discussed on that list OK, I just fixed the issue that was annoying me. Being a PC user, I don't really care about the graphical boot. After touching that code, I believe the 32-bit Linux loader should not parse the vga option at all. It's irrelevant. Instead, the loader should either load the kernel in the current mode (text of gfxterm) or it should restore the text mode. I believe not all kernels can start in graphical mode, so using the graphical mode should be enabled explicitly by some option. If the platform doesn't have text mode, then obviously the current mode should be used. I don't see any strong need to use different video modes in GRUB and in the kernel. If somebody needs that, the mode in GRUB can be changed before loading the kernel. Also, a kernel video driver can change the mode upon initialization using driver-specific parameters. GRUB could implement video mode handling compatible with the Linux internal bootloader, including "vga=ask", but I'm not sure we need it. -- Regards, Pavel Roskin