All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] add clear screen command
Date: Wed, 08 Apr 2009 21:21:17 +0200	[thread overview]
Message-ID: <1239218477.4827.18.camel@fz.local> (raw)
In-Reply-To: <49DCF533.6050809@linux.vnet.ibm.com>

Am Mittwoch, den 08.04.2009, 16:04 -0300 schrieb Carlos Roberto do
Nascimento Costa:
> Hello,
> 
> This simple patch will add a new command to clear the terminal screen. Very
> useful on the command-line.
> 

Hello,

+ *  Copyright (C) 2003,2007  Free Software Foundation, Inc.
+ *  Copyright (C) 2003  NIIBE Yutaka <gniibe@m17n.org>

This should be just `Copyright (C) 2009  Free Software Foundation, Inc.',
because it's a new file from this year.

+  (void)mod;                   /* To stop warning. */
+  cmd = grub_register_command ("clear", grub_cmd_clear,
+               0, "Clear the terminal screen.");

I think there shouldn't be a `0' but `GRUB_COMMAND_FLAG_CMDLINE'.
And please write a ChangeLog entry.

-- 
Felix Zielcke




  reply	other threads:[~2009-04-08 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-08 19:04 [PATCH] add clear screen command Carlos Roberto do Nascimento Costa
2009-04-08 19:21 ` Felix Zielcke [this message]
2009-04-08 19:32   ` phcoder
2009-04-08 22:51     ` Carlos Roberto do Nascimento Costa
2009-04-09 13:44       ` phcoder
2009-04-09 22:16         ` Manoel Rebelo Abranches
2009-04-08 22:34   ` Carlos Roberto do Nascimento Costa
2009-04-08 22:45     ` phcoder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239218477.4827.18.camel@fz.local \
    --to=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.