From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LreKD-0008IQ-Rq for mharc-grub-devel@gnu.org; Wed, 08 Apr 2009 16:24:45 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LreKD-0008IL-01 for grub-devel@gnu.org; Wed, 08 Apr 2009 16:24:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LreK8-0008I9-Cq for grub-devel@gnu.org; Wed, 08 Apr 2009 16:24:44 -0400 Received: from [199.232.76.173] (port=36688 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LreK8-0008I6-9N for grub-devel@gnu.org; Wed, 08 Apr 2009 16:24:40 -0400 Received: from c60.cesmail.net ([216.154.195.49]:27369) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LreK7-0002yD-Vf for grub-devel@gnu.org; Wed, 08 Apr 2009 16:24:40 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 08 Apr 2009 16:24:34 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 590D434C6D for ; Wed, 8 Apr 2009 16:25:49 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <49DC6FCC.2020909@gmail.com> References: <49AEEF72.5050000@gmail.com> <49C3EF85.5080908@gmail.com> <49D726DF.4010601@gmail.com> <200904052348.15540.okuji@enbug.org> <49D9D0E6.5090706@gmail.com> <1239033183.8986.30.camel@mj> <49DA263E.7060803@gmail.com> <1239034857.8986.36.camel@mj> <49DA2CEF.3050404@gmail.com> <1239035609.8986.42.camel@mj> <49DC6FCC.2020909@gmail.com> Content-Type: text/plain Date: Wed, 08 Apr 2009 16:24:31 -0400 Message-Id: <1239222271.2948.22.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] parttool X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Apr 2009 20:24:45 -0000 On Wed, 2009-04-08 at 11:35 +0200, phcoder wrote: > Is this what you mean? Yes. > +static char helpmsg[] = > + "perform COMMANDS on partition.\n" > + "Use \"parttool PARTITION help\" for the list " > + " of available commands"; Please remove one space after "list". I've tested the command quickly. A few notes. We need a command to list the partition table, as "ls" doesn't show the partition types. It would be nice to have some feedback, e.g. parttool (hd0,1) hidden+ Setting partition type to 0x92 "hidden" should work like "hidden+". I prefer plus and minus before the word, not after, but it's a matter of taste. The "hidden" attribute doesn't apply to all partition types. There is no such thing as a hidden Linux swap partition. "parttool PARTITION" should work like "parttool PARTITION help" or maybe it should give information about the partition. Modules for the partition (like "pcpart") should be loaded automatically for any commands including "help". If that module is missing and cannot be loaded, all commands should report is, not just "help". -- Regards, Pavel Roskin