From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ls2Xg-00078P-FK for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 18:16:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls2Xe-00076H-G4 for grub-devel@gnu.org; Thu, 09 Apr 2009 18:16:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls2XZ-00070Z-JZ for grub-devel@gnu.org; Thu, 09 Apr 2009 18:16:13 -0400 Received: from [199.232.76.173] (port=48974 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls2XZ-00070J-EE for grub-devel@gnu.org; Thu, 09 Apr 2009 18:16:09 -0400 Received: from e24smtp05.br.ibm.com ([32.104.18.26]:36008) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ls2XY-0004ul-Qn for grub-devel@gnu.org; Thu, 09 Apr 2009 18:16:09 -0400 Received: from mailhub3.br.ibm.com (mailhub3.br.ibm.com [9.18.232.110]) by e24smtp05.br.ibm.com (8.13.1/8.13.1) with ESMTP id n39MBxab006756 for ; Thu, 9 Apr 2009 19:11:59 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n39MGPmj2093182 for ; Thu, 9 Apr 2009 19:16:26 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n39MG4OI017937 for ; Thu, 9 Apr 2009 19:16:04 -0300 Received: from [9.18.199.148] ([9.18.199.148]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n39MG4or017928 for ; Thu, 9 Apr 2009 19:16:04 -0300 From: Manoel Rebelo Abranches To: The development of GRUB 2 In-Reply-To: <49DDFBAA.6010309@gmail.com> References: <49DCF533.6050809@linux.vnet.ibm.com> <1239218477.4827.18.camel@fz.local> <49DCFBCF.2080004@gmail.com> <49DD2A87.5090609@linux.vnet.ibm.com> <49DDFBAA.6010309@gmail.com> Content-Type: text/plain Date: Thu, 09 Apr 2009 19:16:02 -0300 Message-Id: <1239315362.3478.8.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] add clear screen command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 22:16:14 -0000 On Thu, 2009-04-09 at 15:44 +0200, phcoder wrote: > Carlos Roberto do Nascimento Costa wrote: > > Hello phcoder. thank you for reviewing this patch. > You're welcome > > > > phcoder wrote: > >> Perhaps putting it into normal.mod instead of separate module is a good > >> idea > > > > When I did this patch, I was thinking: clear is a command like ls, lspci, > > reboot, sleep, suspend, halt, exit, etc... so, clear needs to be at commands/ > > dir and follows the same ideas behind other commands. > > > > Is there any reason to not follows this idea? > > > With your patch the created elf contains much more overhead then code. > While it isn't really a problem it's still a thing about which some > thinking is needed > > Best regards, > > > > I think this overhead is not very relevant since this module won't go in the image (created by grub-mkimage). Also it will be consistent with the other commands and better organized(the halt command is actually very similar). -- Best Regards, Manoel Rebelo Abranches IBM Linux Technology Center Brazil