From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ls3Ez-0004vr-JI for mharc-grub-devel@gnu.org; Thu, 09 Apr 2009 19:01:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ls3Ex-0004vi-Nj for grub-devel@gnu.org; Thu, 09 Apr 2009 19:00:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ls3Es-0004vW-2p for grub-devel@gnu.org; Thu, 09 Apr 2009 19:00:58 -0400 Received: from [199.232.76.173] (port=47802 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ls3Es-0004vT-0e for grub-devel@gnu.org; Thu, 09 Apr 2009 19:00:54 -0400 Received: from e24smtp05.br.ibm.com ([32.104.18.26]:39692) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ls3Er-0002vB-4K for grub-devel@gnu.org; Thu, 09 Apr 2009 19:00:53 -0400 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by e24smtp05.br.ibm.com (8.13.1/8.13.1) with ESMTP id n39MueXT028899 for ; Thu, 9 Apr 2009 19:56:40 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3A005Xt2977904 for ; Thu, 9 Apr 2009 21:00:05 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n39N0ke9023379 for ; Thu, 9 Apr 2009 20:00:46 -0300 Received: from [9.18.199.148] ([9.18.199.148]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n39N0j0X023375 for ; Thu, 9 Apr 2009 20:00:46 -0300 From: Manoel Rebelo Abranches To: The development of GRUB 2 In-Reply-To: <20090409.140532.24918882.davem@davemloft.net> References: <20090407.170327.247321919.davem@davemloft.net> <20090409.140532.24918882.davem@davemloft.net> Content-Type: text/plain Date: Thu, 09 Apr 2009 20:00:43 -0300 Message-Id: <1239318043.3478.11.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH]: grub: Fix type of 'actual' size arguments to ieee1275 interfaces. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2009 23:01:00 -0000 This patch is ok. it shouldn't be int. On Thu, 2009-04-09 at 14:05 -0700, David Miller wrote: > From: David Miller > Date: Tue, 07 Apr 2009 17:03:27 -0700 (PDT) > > > The 'actual' argument to various ieee1275 functions is of type > > "grub_ssize_t" but several spots were erroneously using "int". > > > > This happens to work on powerpc but does not on sparc64. > > > > 2009-04-07 David S. Miller > > > > * kern/ieee1275/init.c (grub_machine_init): Make 'actual' grub_ssize_t. > > * kern/ieee1275/openfw.c (grub_children_iterate): Likewise. > > (grub_devalias_iterate): Likewise. > > Ping? Review appreciated, thanks! > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Best Regards, Manoel Rebelo Abranches IBM Linux Technology Center Brazil