From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
"ath5k-devel@lists.ath5k.org" <ath5k-devel@lists.ath5k.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [ath5k-devel] BUG in wiphy_update_regulatory when loading ath5k (on latest git)
Date: Fri, 10 Apr 2009 16:21:04 -0400 [thread overview]
Message-ID: <1239394864.3673.2.camel@mj> (raw)
In-Reply-To: <20090410181157.GC5750@tesla>
On Fri, 2009-04-10 at 11:11 -0700, Luis R. Rodriguez wrote:
> Thanks pavel, please try this patch:
I checked ath5k, ath9k and b43, and in all cases last_request is
initialized before it's used by the code changed in your patch. In
fact, last_request is initialized before there is any message from ath5k
or another driver.
I wonder if "module: create a request_module_nowait()" reverted in
wireless-testing was causing the initialization to go in a different
order. I tried reapplying it and still could not reproduce the problem
(that is, last_request is not NULL in wiphy_update_regulatory). But
maybe I'm just lucky.
Anyway, your patch makes the code safer and doesn't break anything for
me.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-04-10 20:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 15:13 Weird oops in wiphy_update_regulatory after having loaded ath5k (on latest git) Alan Jenkins
2009-04-10 15:13 ` Alan Jenkins
[not found] ` <49DF6216.8040303-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-10 16:18 ` BUG in wiphy_update_regulatory when loading " Alan Jenkins
2009-04-10 16:18 ` Alan Jenkins
2009-04-10 16:18 ` Alan Jenkins
[not found] ` <49DF714F.9070600-cCz0Lq7MMjm9FHfhHBbuYA@public.gmane.org>
2009-04-10 17:15 ` Luis R. Rodriguez
2009-04-10 17:15 ` [ath5k-devel] " Luis R. Rodriguez
2009-04-10 17:15 ` Luis R. Rodriguez
2009-04-10 17:45 ` Pavel Roskin
2009-04-10 18:11 ` Luis R. Rodriguez
2009-04-10 20:21 ` Pavel Roskin [this message]
2009-04-10 20:30 ` Alan Jenkins
2009-04-10 22:26 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239394864.3673.2.camel@mj \
--to=proski@gnu.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=ath5k-devel@lists.ath5k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.