From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit.
Date: Sat, 11 Apr 2009 23:21:39 -0400 [thread overview]
Message-ID: <1239506499.4007.10.camel@mj> (raw)
In-Reply-To: <49E0EB22.4070308@gmail.com>
On Sat, 2009-04-11 at 21:10 +0200, phcoder wrote:
> I do not agree with having separate grub_itoa/grub_ltoa/grub_lltoa in
> kernel where the size is critical.
Nice catch!
> We should have only lltoa and use it
> in all contexts. I know because of divmod64 it's slower than ltoa or
> itoa but it's used only for output so speed isn't so important
I agree.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-04-12 3:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 8:08 [PATCH]: grub: Fix handling of long printf arguments on 64-bit David Miller
2009-04-11 10:19 ` Yoshinori K. Okuji
2009-04-11 11:48 ` David Miller
2009-04-11 19:10 ` phcoder
2009-04-12 3:21 ` Pavel Roskin [this message]
2009-04-12 8:07 ` David Miller
2009-04-12 12:46 ` phcoder
2009-04-12 14:19 ` Isaac Dupree
2009-04-12 21:36 ` Pavel Roskin
2009-04-12 21:33 ` Pavel Roskin
2009-04-12 21:51 ` Pavel Roskin
2009-04-12 22:19 ` phcoder
2009-04-13 5:23 ` Pavel Roskin
2009-04-15 12:46 ` phcoder
2009-04-12 6:39 ` Pavel Roskin
2009-04-12 8:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239506499.4007.10.camel@mj \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.