From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LsqlP-0003xC-Vc for mharc-grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsqlN-0003uf-N7 for grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsqlI-0003p9-BJ for grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:44 -0400 Received: from [199.232.76.173] (port=38185 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsqlI-0003p6-1r for grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:40 -0400 Received: from mx20.gnu.org ([199.232.41.8]:63062) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LsqlH-0001Q3-F5 for grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LsqlG-0008Vz-Gw for grub-devel@gnu.org; Sat, 11 Apr 2009 23:53:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 11 Apr 2009 23:53:34 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id E507534C6A for ; Sat, 11 Apr 2009 23:55:00 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090411.012731.101657495.davem@davemloft.net> References: <20090411.012731.101657495.davem@davemloft.net> Content-Type: text/plain Date: Sat, 11 Apr 2009 23:53:33 -0400 Message-Id: <1239508413.6491.11.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH]: Fix fs modules on sparc64 build with newer gcc X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 03:53:45 -0000 On Sat, 2009-04-11 at 01:27 -0700, David Miller wrote: > Newer versions of gcc emit references to libgcc internal > functions __bswapsi2 and __bswapdi2 when building ufs and > some other filesystem modules on sparc64. > > Unfortunately older versions of gcc lack these symbols in > libgcc so we can't export them universally, we have to check > for it using configure link tests. > > I commited this under the "trust dave with sparc stuff" rule. > Let me know if it that wasn't appropriate in this case :-) Actually, changes to configure.ac affect other users as well. Users of other architectures would have to run those checks. I would try to use weak functions or something like that. Failing that, I would add a check for affected architectures only. Even if that would make the script longer, it would make it clear which architectures need the check, which is probably a good idea. > I also rebuild configure when commiting these changes. I see that configure and config.h.in we built by different versions of autoconf. That's likely to break. I would run autogen.sh and commit all changed files after examining the changes. As a courtesy to others, I install the same version of Autoconf that the current configure script was generated with. Adding or removing files means that DISTLIST will change. That should be committed as well. Personally, I would remove all files generated by autogen.sh from the repository. But I don't want to do something that is inconvenient to others. The issue was discussed in the past and the decision was to keep those files. -- Regards, Pavel Roskin