From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LstLp-0003pk-0Z for mharc-grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LstLn-0003pd-Vx for grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LstLi-0003pN-0R for grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:30 -0400 Received: from [199.232.76.173] (port=37499 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LstLh-0003pK-SH for grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:25 -0400 Received: from mx20.gnu.org ([199.232.41.8]:3791) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LstLh-0002uE-F2 for grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:25 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LstLg-0005z8-Dq for grub-devel@gnu.org; Sun, 12 Apr 2009 02:39:25 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 12 Apr 2009 02:39:24 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 9237034C6A for ; Sun, 12 Apr 2009 02:40:50 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090411.010829.45951849.davem@davemloft.net> References: <20090411.010829.45951849.davem@davemloft.net> Content-Type: text/plain Date: Sun, 12 Apr 2009 02:39:22 -0400 Message-Id: <1239518362.3887.29.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 06:39:32 -0000 On Sat, 2009-04-11 at 01:08 -0700, David Miller wrote: > The grub printf code tries to treat 'long' and 'int' the same, > that doesn't work on (most) 64-bit platforms. > + n = (unsigned) (-((long) n)); "unsigned" means "unsigned int". You need "unsigned long" here. It's probably irrelevant if we kill grub_ltoa(), but anyway, let's be careful. -- Regards, Pavel Roskin