From: Mattia Dongili <malattia@linux.it>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, "Almer S. Tigelaar" <almer@gnome.org>,
Mattia Dongili <malattia@linux.it>,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: [PATCH 4/6] ec.c: Fix ACPI EC resume non-query interrupt message
Date: Sun, 12 Apr 2009 20:26:29 +0900 [thread overview]
Message-ID: <1239535591-15514-5-git-send-email-malattia@linux.it> (raw)
In-Reply-To: <1239535591-15514-4-git-send-email-malattia@linux.it>
From: Almer S. Tigelaar <almer@gnome.org>
When resuming from standby (on a laptop) I see the following message in
my kernel.log:
"ACPI: EC: non-query interrupt received, switching to interrupt mode"
This apparently prevented sony-laptop to properly restore the brightness
level on resume.
The cause: In drivers/acpi/ec.c the acpi_ec_suspend function clears the
GPE mode bit, but this is not restored in acpi_ec_resume (the function
below it). The patch below fixes this by properly restoring the GPE_MODE
bit. Tested and confirmed to work.
Signed-off-by: Almer S. Tigelaar <almer@gnome.org>
Signed-off-by: Mattia Dongili <malattia@linux.it>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>
---
drivers/acpi/ec.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 04e9044..391f331 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1065,6 +1065,7 @@ static int acpi_ec_resume(struct acpi_device *device)
struct acpi_ec *ec = acpi_driver_data(device);
/* Enable use of GPE back */
clear_bit(EC_FLAGS_NO_GPE, &ec->flags);
+ set_bit(EC_FLAGS_GPE_MODE, &ec->flags);
acpi_enable_gpe(NULL, ec->gpe);
return 0;
}
--
1.6.2.2
next prev parent reply other threads:[~2009-04-12 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 11:26 [PATCH 0/6] sony-laptop fixes for 2.6.30-rc2 Mattia Dongili
2009-04-12 11:26 ` [PATCH 1/6] sony-laptop: Duplicate SNC 127 Event Fix Mattia Dongili
2009-04-12 11:26 ` [PATCH 2/6] sony-laptop: SNC 127 Initialization Fix Mattia Dongili
2009-04-12 11:26 ` [PATCH 3/6] sony-laptop: SNC input event 38 fix Mattia Dongili
2009-04-12 11:26 ` Mattia Dongili [this message]
2009-04-12 11:26 ` [PATCH 5/6] sony-laptop: fix bogus error message display on resume Mattia Dongili
2009-04-12 11:26 ` [PATCH 6/6] sony-laptop: always try to unblock rfkill on load Mattia Dongili
2009-04-13 15:46 ` Matthew Garrett
2009-04-18 5:16 ` [PATCH 0/6] sony-laptop fixes for 2.6.30-rc2 Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239535591-15514-5-git-send-email-malattia@linux.it \
--to=malattia@linux.it \
--cc=almer@gnome.org \
--cc=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.