From: Pavel Roskin <proski@gnu.org>
To: grub-devel <grub-devel@gnu.org>
Subject: Re: [PATCH]: grub: Fix ofdisk disk cache corruption.
Date: Sun, 12 Apr 2009 17:01:07 -0400 [thread overview]
Message-ID: <1239570067.14481.14.camel@ct> (raw)
In-Reply-To: <20090412.010121.183222401.davem@davemloft.net>
On Sun, 2009-04-12 at 01:01 -0700, David Miller wrote:
> > That's a 3 bit hash. The risk of collisions is very high. I would
> > understand if you had 8 entries for the hash values, but the hash values
> > themselves should be reasonably unique.
>
> In my testing there weren't many collisions.
>
> I think fixing disk cache corruption is more important than
> arguing over the distribution properties of the hash function
> I have choosen.
>
> Right?
It's not just about distribution properties. My impression is that your
code misuses hashes as indices in a table. Let's make the hash 32-bit.
That would make it harder to misuse.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-04-12 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 8:08 [PATCH]: grub: Fix ofdisk disk cache corruption David Miller
2009-04-12 6:29 ` Pavel Roskin
2009-04-12 8:01 ` David Miller
2009-04-12 10:44 ` phcoder
2009-04-13 1:02 ` David Miller
2009-04-13 1:09 ` phcoder
2009-04-13 6:42 ` David Miller
2009-04-12 21:01 ` Pavel Roskin [this message]
2009-04-13 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239570067.14481.14.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.