From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Lt7Lm-0006dO-Nb for mharc-grub-devel@gnu.org; Sun, 12 Apr 2009 17:36:26 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lt7Ll-0006ct-Lj for grub-devel@gnu.org; Sun, 12 Apr 2009 17:36:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lt7Lh-0006b2-8z for grub-devel@gnu.org; Sun, 12 Apr 2009 17:36:25 -0400 Received: from [199.232.76.173] (port=35134 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lt7Lh-0006as-13 for grub-devel@gnu.org; Sun, 12 Apr 2009 17:36:21 -0400 Received: from c60.cesmail.net ([216.154.195.49]:58958) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Lt7Lg-0002Ml-No for grub-devel@gnu.org; Sun, 12 Apr 2009 17:36:20 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 12 Apr 2009 17:36:20 -0400 Received: from [192.168.0.220] (pool-141-151-93-148.phlapa.east.verizon.net [141.151.93.148]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id A49B634C6A for ; Sun, 12 Apr 2009 17:37:48 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <200904121019.18535.ml@isaac.cedarswampstudios.org> References: <200904111919.49761.okuji@enbug.org> <20090412.010719.229891360.davem@davemloft.net> <49E1E2BC.3020405@gmail.com> <200904121019.18535.ml@isaac.cedarswampstudios.org> Content-Type: text/plain Date: Sun, 12 Apr 2009 17:36:18 -0400 Message-Id: <1239572178.14481.35.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH]: grub: Fix handling of long printf arguments on 64-bit. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2009 21:36:25 -0000 On Sun, 2009-04-12 at 10:19 -0400, Isaac Dupree wrote: > > - grub_ltoa (tmp, c, l); > > + grub_lltoa (tmp, c, l); > > } > > else > > { > > n = va_arg (args, int); > > - grub_itoa (tmp, c, n); > > + grub_lltoa (tmp, c, n); > > Do you think they deserve a comment saying why lltoa and that e.g. grub_ltoa > would work equally well there except for space reasons? (In case we ever > decided to change that code back, it would be easier to figure out.) If somebody wants to change the code back, that person would need to justify adding two functions to kern/misc.c, which is part of the GRUB core and should be kept minimal. I don't think it will be easy to justify. -- Regards, Pavel Roskin