From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LtEKC-0003rV-75 for mharc-grub-devel@gnu.org; Mon, 13 Apr 2009 01:03:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtEKB-0003rG-6H for grub-devel@gnu.org; Mon, 13 Apr 2009 01:03:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtEK6-0003qv-In for grub-devel@gnu.org; Mon, 13 Apr 2009 01:03:14 -0400 Received: from [199.232.76.173] (port=57400 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtEK6-0003qr-DK for grub-devel@gnu.org; Mon, 13 Apr 2009 01:03:10 -0400 Received: from c60.cesmail.net ([216.154.195.49]:60132) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LtEK5-0006c9-T3 for grub-devel@gnu.org; Mon, 13 Apr 2009 01:03:10 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Apr 2009 01:03:08 -0400 Received: from [192.168.0.220] (pool-141-151-93-148.phlapa.east.verizon.net [141.151.93.148]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 1AC2D34C6A; Mon, 13 Apr 2009 01:04:38 -0400 (EDT) From: Pavel Roskin To: David Miller In-Reply-To: <20090412.180707.168779439.davem@davemloft.net> References: <200904111909.48927.okuji@enbug.org> <200904110830.02945.colin@gibibit.com> <1239571489.14481.24.camel@ct> <20090412.180707.168779439.davem@davemloft.net> Content-Type: text/plain Date: Mon, 13 Apr 2009 01:03:01 -0400 Message-Id: <1239598981.4166.8.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: grub-devel@gnu.org Subject: Re: [PATCH] Build system improvement X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 05:03:15 -0000 On Sun, 2009-04-12 at 18:07 -0700, David Miller wrote: > From: Pavel Roskin > Date: Sun, 12 Apr 2009 17:24:49 -0400 > > > On Sat, 2009-04-11 at 08:29 -0700, Colin D Bennett wrote: > > > >> If we could build with -Werror, then it wouldn't be so hard to find the > >> warnings since the build would abort... > > > > It's also possible to redirect stderr to a file so that the build > > doesn't stumble on the first warning. > > I'm iffy about this. I meant that "warning hunters" can use it and have a choice what warnings to fix. I didn't suggest stderr redirection to be part of the build system. > There are some hard warnings to get rid of. > > For example when building certain grub-* tools there is no way > to get around the current redefinitions we get of LONG_MAX and > friends. (one comes in via grub headers, then the stdio.h include > gets us the system definition, we can't use ifdef guards because > the grub headers come in and define things first) I would explore the possibility of introducing GRUB_LONG_MAX. GRUB already duplicates a lot of libc definitions. Sure enough, forcing developers to keep the code warning-free could lead to ugly fixes that are worse that the original warnings. However, keeping the build system quiet will help more people notice the warnings. Somebody will come with a nice fix eventually. -- Regards, Pavel Roskin