From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LtNuI-0002Xh-RY for mharc-grub-devel@gnu.org; Mon, 13 Apr 2009 11:17:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtNuF-0002Ur-JS for grub-devel@gnu.org; Mon, 13 Apr 2009 11:17:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtNuB-0002TI-0K for grub-devel@gnu.org; Mon, 13 Apr 2009 11:17:07 -0400 Received: from [199.232.76.173] (port=51048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtNuA-0002TE-Rj for grub-devel@gnu.org; Mon, 13 Apr 2009 11:17:02 -0400 Received: from c60.cesmail.net ([216.154.195.49]:52616) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LtNuA-0007yC-I5 for grub-devel@gnu.org; Mon, 13 Apr 2009 11:17:02 -0400 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 13 Apr 2009 11:16:48 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 5C08034C69 for ; Mon, 13 Apr 2009 11:16:51 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090413141657.GE12170@thorin> References: <1239032043.8986.27.camel@mj> <20090413141657.GE12170@thorin> Content-Type: text/plain Date: Mon, 13 Apr 2009 11:16:46 -0400 Message-Id: <1239635806.18804.8.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Video mode fixes in linux loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 15:17:07 -0000 On Mon, 2009-04-13 at 16:16 +0200, Robert Millan wrote: > Hi Pavel, > > On Mon, Apr 06, 2009 at 11:34:03AM -0400, Pavel Roskin wrote: > > Hello! > > > > This is an attempt to fix all issues with the video mode handling in the > > new Linux loader. > > Please, in general, when you modify code that has been actively worked on > by someone, try to get that person involved. I tried, but probably not hard enough. Sorry. > > The default VGA mode is now GRUB_LINUX_VID_MODE_NORMAL, not the mode of > > the kernel we tried to load before. > > Ok, BUT if we're already in vesa mode, and we know it works (since we're using > it), there's no point in wasting time only to get a worse mode. Maybe we should introduce another macro, e.g. GRUB_LINUX_VID_MODE_CURRENT, recognize it in the loader and default to it. > We should just make sure subsequent calls to "linux" command override the > previous one. Yes, failed loading of one kernel should not affect loading of another kernel. That was the most annoying bug, and I hope it's fixed now. > > Finally, "vga=ask" is now recognized. > > With the new loader, Linux' 16-bit entry code is no longer responsible for > setting vesa modes, therefore vga=ask can't work. There's no point in > recognizing it (except to warn the user). I agree. Generally, "vga=random_string" causes an error now. Perhaps any unrecognized values of "vga" should cause a warning, not an error. -- Regards, Pavel Roskin