From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LtOI6-0005wZ-5d for mharc-grub-devel@gnu.org; Mon, 13 Apr 2009 11:41:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LtOI4-0005wM-Vn for grub-devel@gnu.org; Mon, 13 Apr 2009 11:41:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LtOI0-0005vJ-3k for grub-devel@gnu.org; Mon, 13 Apr 2009 11:41:44 -0400 Received: from [199.232.76.173] (port=51116 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LtOHz-0005vF-Up for grub-devel@gnu.org; Mon, 13 Apr 2009 11:41:39 -0400 Received: from c60.cesmail.net ([216.154.195.49]:31207) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LtOHy-000517-Rz for grub-devel@gnu.org; Mon, 13 Apr 2009 11:41:39 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 Apr 2009 11:41:37 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id EAF6034C6A for ; Mon, 13 Apr 2009 11:43:08 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090413144558.GA22165@thorin> References: <1239032043.8986.27.camel@mj> <20090413141657.GE12170@thorin> <20090413144558.GA22165@thorin> Content-Type: text/plain Date: Mon, 13 Apr 2009 11:41:36 -0400 Message-Id: <1239637296.3549.9.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Video mode fixes in linux loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 15:41:45 -0000 On Mon, 2009-04-13 at 16:45 +0200, Robert Millan wrote: > On Mon, Apr 13, 2009 at 04:16:57PM +0200, Robert Millan wrote: > > > The default VGA mode is now GRUB_LINUX_VID_MODE_NORMAL, not the mode of > > > the kernel we tried to load before. > > > > Ok, BUT if we're already in vesa mode, and we know it works (since we're using > > it), there's no point in wasting time only to get a worse mode. > > > > We should just make sure subsequent calls to "linux" command override the > > previous one. > > I think this should do it. Can you confirm this works for you? I actually installed GRUB with gfxterm on a laptop that has Intel framebuffer support. Now the kernel starts in VESA mode and then the screen goes blank because intelfb cannot deal with it. Sure, intelfb should be fixed, but we should be liberal in what we accept. Some kernels may not support VESA modes at all. Adding vga=0 to the kernel command line didn't fix it. That's bad. "vga=0" means text mode 80x25. Adding "vga=1" fixed the problem. The text mode was 80x25, not 80x50, so that's another issue. "vga=ask" is not a warning now. It causes "error: You need to load the kernel first", apparently from initrd. In other words, the "linux" command fails and there is no visible warning. -- Regards, Pavel Roskin