From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ltt2c-0007C1-CT for mharc-grub-devel@gnu.org; Tue, 14 Apr 2009 20:31:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ltt2a-0007BT-Th for grub-devel@gnu.org; Tue, 14 Apr 2009 20:31:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ltt2W-00079W-E3 for grub-devel@gnu.org; Tue, 14 Apr 2009 20:31:48 -0400 Received: from [199.232.76.173] (port=36866 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ltt2W-00079G-4B for grub-devel@gnu.org; Tue, 14 Apr 2009 20:31:44 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51105) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Ltt2V-000228-Qy for grub-devel@gnu.org; Tue, 14 Apr 2009 20:31:43 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 14 Apr 2009 20:31:38 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 4267B34C6A for ; Tue, 14 Apr 2009 20:33:13 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <200904150045.46154.okuji@enbug.org> References: <20090411005826.oahebrl8ys0w0o0k-cebfxv@webmail.spamcop.net> <200904111919.22519.okuji@enbug.org> <20090411091658.bv4254n00sk00000-cebfxv@webmail.spamcop.net> <200904150045.46154.okuji@enbug.org> Content-Type: text/plain Date: Tue, 14 Apr 2009 20:31:35 -0400 Message-Id: <1239755495.3439.29.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix target tool check logic X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 00:31:49 -0000 On Wed, 2009-04-15 at 00:45 +0900, Yoshinori K. Okuji wrote: > On Saturday 11 April 2009 22:16:58 Pavel Roskin wrote: > > Quoting "Yoshinori K. Okuji" : > > > "test -n" should be avoided. Maybe this is not necessary nowadays, but my > > > old lesson was to use "test x$target_alias != x" instead for portability. > > > Well, "!=" was not very portable, either, maybe. > > > > I believe both "-n" and "!=" are found in Autoconf sources that are > > turned into configure scripts. Anyway, I'll use the syntax you want. > > Even if this looks obsolete, I think it is better to follow the > chapter "Limitations of Builtins" in the autoconf manual: Thanks. The Autoconf code I was referring to didn't involve any possibility of pathological arguments. But we are dealing with user input here (target_alias comes from the command line), so you are right, it's better to err on the safe side. -- Regards, Pavel Roskin