From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Luq8S-0007Qn-7d for mharc-grub-devel@gnu.org; Fri, 17 Apr 2009 11:37:48 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Luq8Q-0007Px-Ha for grub-devel@gnu.org; Fri, 17 Apr 2009 11:37:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Luq8M-0007Oc-08 for grub-devel@gnu.org; Fri, 17 Apr 2009 11:37:46 -0400 Received: from [199.232.76.173] (port=44086 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Luq8L-0007OW-SR for grub-devel@gnu.org; Fri, 17 Apr 2009 11:37:41 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51586) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1Luq8H-0000az-Nf for grub-devel@gnu.org; Fri, 17 Apr 2009 11:37:40 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 17 Apr 2009 11:37:37 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id C9D1434C6D for ; Fri, 17 Apr 2009 11:39:20 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090417143953.GA24704@localdomain> References: <20090415213416.GA27790@localdomain> <1239832242.8204.3.camel@mj> <20090417143953.GA24704@localdomain> Content-Type: text/plain Date: Fri, 17 Apr 2009 11:37:35 -0400 Message-Id: <1239982655.4383.0.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: r2074 broke ata module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2009 15:37:46 -0000 On Fri, 2009-04-17 at 10:39 -0400, Ward Vandewege wrote: > On Wed, Apr 15, 2009 at 05:50:42PM -0400, Pavel Roskin wrote: > > On Wed, 2009-04-15 at 17:34 -0400, Ward Vandewege wrote: > > > Hi there, > > > > > > I tried to use the ata module today in combination with grub2's coreboot > > > code, but found that it broke in r2074, specifically by this hunk: > > > > Actually, I was looking at the warnings, and it looks like the warnings > > about grub_pci_iterate() are directly related to this problem. > > > > This patch should help. > > Confirmed, this fixes ata for me. Committed. -- Regards, Pavel Roskin