All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove crc32c.h and use libcrc32c directly.
Date: Mon, 20 Apr 2009 00:41:05 +0100	[thread overview]
Message-ID: <1240184465.11524.0.camel@macbook.infradead.org> (raw)
In-Reply-To: <1240183836.10853.1.camel@think.oraclecorp.com>

On Sun, 2009-04-19 at 19:30 -0400, Chris Mason wrote:
> On Mon, 2009-04-20 at 00:19 +0100, David Woodhouse wrote:
> > On Sun, 2009-04-19 at 19:11 -0400, Chris Mason wrote:
> > > How does this enable the HW crc32c?  Unless I'm missing something you're
> > > doing crc32c instead of btrfs_crc32c, but btrfs_crc32c was #defined to
> > > crc32c?
> > 
> > It doesn't. You're _already_ using the hardware crc32c.
> > 
> 
> Ok, that makes more sense ;) I'll fixup the changelog when I merge the
> patch. 

The changelog already said "libcrc32c now does that for us
through the crypto API -- so we're already using the Intel crc32c
acceleration where appropriate, without having to do anything special."

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


      reply	other threads:[~2009-04-19 23:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-19 12:02 [PATCH] btrfs: remove crc32c.h and use libcrc32c directly David Woodhouse
2009-04-19 23:11 ` Chris Mason
2009-04-19 23:19   ` David Woodhouse
2009-04-19 23:30     ` Chris Mason
2009-04-19 23:41       ` David Woodhouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240184465.11524.0.camel@macbook.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.