Re: [Qemu-devel] [BUG] -usb makes qemu fight against linux

[Paul Bolle <pebolle@tiscali.nl>]

On Fri, 2009-04-24 at 12:05 +0200, Paul Bolle wrote:
> On Fri, 2009-03-06 at 09:54 +0100, Stan Behrens wrote:
> This seems related to this discussion:
> http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01320.html (in a
> thread regarding a preliminary patch to implement ehci).
> 
> Could you try the following patch? It was created after finally
> discovering the discussion mentioned above (which I hardly understand,
> which in turn leads to an impressive, but possibly nonsensical commit
> message for this patch). It seems to fix a similar issue I ran into
> (while trying some advanced feature of a USB memory stick I happen to
> have.)

I just found a slightly different and, I guess, better solution here:
http://lists.gnu.org/archive/html/qemu-devel/2008-10/msg01326.html (I
seem to have missed this messages in that archive as it is, for some
reason, a separate thread).

I simply copied it from that address into this mail. It will probably
not apply without manual adjustments.


Paul Bolle
---
Index: usb-linux.c
===================================================================
--- usb-linux.c (revision 5571)
+++ usb-linux.c (working copy)
@@ -68,7 +68,7 @@
 static int usb_host_find_device(int *pbus_num, int *paddr,
                                 char *product_name, int
product_name_size,
                                 const char *devname);
-//#define DEBUG
+// #define DEBUG
 
 #ifdef DEBUG
 #define dprintf printf
@@ -276,7 +276,9 @@
 
             case -EPIPE:
                 set_halt(s, p->devep);
-                /* fall through */
+               p->len = USB_RET_STALL;
+               break;
+
             default:
                 p->len = USB_RET_NAK;
                 break;