All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark McLoughlin <markmc@redhat.com>
To: avi@redhat.com
Cc: kvm@vger.kernel.org, Mark McLoughlin <markmc@redhat.com>
Subject: [PATCH] kvm: qemu: net: unbreak tap networking
Date: Tue, 28 Apr 2009 09:48:20 +0100	[thread overview]
Message-ID: <1240908500-25598-1-git-send-email-markmc@redhat.com> (raw)

A recent merge broke tap networking because qemu_send_packet()
now always returns -EAGAIN causing tap to try and resend the
same packet forever.

Fix by having qemu_send_packet() return the status from the
qemu_deliver_packet() of the packet in question, rather than
any packets which happened to have been queued up during the
delivery of the original packet.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
 net.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net.c b/net.c
index 16f6e48..b5ebcea 100644
--- a/net.c
+++ b/net.c
@@ -445,9 +445,9 @@ int qemu_send_packet(VLANClientState *vc, const uint8_t *buf, int size)
         vlan->send_queue = packet;
     } else {
         vlan->delivering = 1;
-        qemu_deliver_packet(vc, buf, size);
+        ret = qemu_deliver_packet(vc, buf, size);
         while ((packet = vlan->send_queue) != NULL) {
-            ret = qemu_deliver_packet(packet->sender, packet->data, packet->size);
+            qemu_deliver_packet(packet->sender, packet->data, packet->size);
             vlan->send_queue = packet->next;
             qemu_free(packet);
         }
-- 
1.6.0.6


             reply	other threads:[~2009-04-28  8:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28  8:48 Mark McLoughlin [this message]
2009-04-28  8:58 ` [PATCH] kvm: qemu: net: unbreak tap networking Avi Kivity
2009-04-28 10:10   ` Mark McLoughlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1240908500-25598-1-git-send-email-markmc@redhat.com \
    --to=markmc@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.