From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Post <echo@echoreply.us>
Subject: [PATCH] 1/1 Better expose xenstore limits
Date: Thu, 30 Apr 2009 00:43:03 +0800
Message-ID: <1241023383.5394.162.camel@localhost.localdomain>
Reply-To: echo@echoreply.us
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-aBjYa4Wl9Gw1s96wcKFm"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


--=-aBjYa4Wl9Gw1s96wcKFm
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

The attached patch announces the limits regarding:

XENSTORE_PAYLOAD_MAX, XENSTORE_ABS_PATH_MAX and XENSTORE_REL_PATH_MAX in
the public xs.h.

These are already defined in xs_wire, however, not many people dig that
far when using xs.h.

Since xs.h already includes xs_wire, this patch duplicates those limits
as XS_PAYLOAD_MAX, XS_ABS_PATH_MAX and XS_REL_PATH_MAX. Moving these
would be a pain, but they really need to be advertised.

Such limits should be obvious in the headers that people actually use
outside of the kernel, saving them from wondering what went wrong.

Added comments direct people to xs_wire.h , in case those limits change.

Signed-off-by: Tim Post <echo@echoreply.us>



--=-aBjYa4Wl9Gw1s96wcKFm
Content-Disposition: attachment; filename=xenstore-expose-limits.patch
Content-Type: text/x-patch; name=xenstore-expose-limits.patch; charset=UTF-8
Content-Transfer-Encoding: 7bit

diff -r dc5bd14a4675 tools/xenstore/xs.h
--- a/tools/xenstore/xs.h	Fri Apr 24 13:46:17 2009 +0100
+++ b/tools/xenstore/xs.h	Thu Apr 30 00:39:14 2009 +0800
@@ -23,6 +23,11 @@
 #include <xs_lib.h>
 
 #define XBT_NULL 0
+
+/* Please see xen/io/xs_wire.h for more explantion on these limits */
+#define XS_PAYLOAD_MAX XENSTORE_PAYLOAD_MAX
+#define XS_ABS_PATH_MAX XENSTORE_ABS_PATH_MAX
+#define XS_REL_PATH_MAX XENSTORE_REL_PATH_MAX
 
 struct xs_handle;
 typedef uint32_t xs_transaction_t;

--=-aBjYa4Wl9Gw1s96wcKFm
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--=-aBjYa4Wl9Gw1s96wcKFm--