From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Post Subject: Re: [PATCH] 1/1 Better expose xenstore limits Date: Thu, 30 Apr 2009 16:54:51 +0800 Message-ID: <1241081691.5394.192.camel@localhost.localdomain> References: Reply-To: echo@echoreply.us Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Wed, 2009-04-29 at 22:23 +0100, Keir Fraser wrote: > On 29/04/2009 19:18, "Tim Post" wrote: > > > Someone using xs.h is going to be entirely unaware of said limits. > > Xenstore internals will relay an appropriate errno if the limits are > > exceeded, but I think many people will not know such limits exist. > > > > Xenwire is used when developing drivers.. not user space applications. > > > > Why not assert the limits in both at the cost of bothering the > > preprocessor three times? > > Defining the same thing again but with a different name just for purposes of > documentation is pretty barking. I suppose it is perhaps worth a > documentation comment in xs.h, but no more than that. It is worth a mention... though it seems silly to send a patch that adds comments. However, a patch that would convert the comments in xs to doxygen format seems more useful, with the appropriate grouping, shorts, etc. How receptive would you be to that? Cheers, --Tim