Re: [PATCH] powerpc/pci: Move pseries code into pseries platform specific area

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]

On Thu, 2009-04-30 at 10:35 -0500, Kumar Gala wrote:
> On Apr 30, 2009, at 9:49 AM, Michael Ellerman wrote:
> 
> > On Thu, 2009-04-30 at 09:14 -0500, Kumar Gala wrote:
> >> There doesn't appear to be any specific reason that we need to  
> >> setup the
> >> pseries specific notifier in generic arch pci code.  Move it into  
> >> pseries
> >> land.
> >
> > Yeah I guess. Although if some other platform ever wants to do PCI
> > hotplug it probably wants to call update_dn_pci_info() also.
> 
> when that happens we can worry about, also the code I moved is pretty  
> pseries specific  (seeing as the event is called PSERIES_RECONFIG_ADD)

Yeah I agree.

> >> --- a/arch/powerpc/platforms/pseries/setup.c
> >> +++ b/arch/powerpc/platforms/pseries/setup.c
> >> @@ -254,6 +255,31 @@ static void __init pseries_discover_pic(void)
> >>               " interrupt-controller\n");
> >> }
> >>
> >> +extern void * update_dn_pci_info(struct device_node *dn, void  
> >> *data);
> >
> > Ahem :)
> 
> Yeah, was being lazy.  I'll move it into asm/pci-bridge.h

Please do :)

cheers


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]