From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC v14][PATCH 08/54] Dump memory address space Date: Fri, 01 May 2009 08:25:38 -0700 Message-ID: <1241191538.29485.175.camel@nimitz> References: <1240961064-13991-1-git-send-email-orenl@cs.columbia.edu> <1240961064-13991-9-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1240961064-13991-9-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Alexey Dobriyan List-Id: containers.vger.kernel.org On Tue, 2009-04-28 at 19:23 -0400, Oren Laadan wrote: > +struct ckpt_pgarr { > + unsigned long *vaddrs; > + struct page **pages; > + unsigned int nr_used; > + struct list_head list; > +}; > + > +#define CKPT_PGARR_TOTAL (PAGE_SIZE / sizeof(void *)) > +#define CKPT_PGARR_CHUNK (4 * CKPT_PGARR_TOTAL) I seem to get irrationally angry in the presence of 'clumps', 'chunks', and other non-descriptive variable names in mm code. :) Anyway, this is only used in one place, but it might be better to call it: CKPT_PAGES_AT_ONCE or CKPT_PGARR_BATCH Batching up 4 at once doesn't seem that great of a win to me. Why bother adding another loop and another variable unless the batch size is bigger? -- Dave