From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0TQ5-0001MB-Nz for mharc-grub-devel@gnu.org; Sun, 03 May 2009 00:35:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0TQ3-0001M5-P7 for grub-devel@gnu.org; Sun, 03 May 2009 00:35:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0TPy-0001LB-AW for grub-devel@gnu.org; Sun, 03 May 2009 00:35:14 -0400 Received: from [199.232.76.173] (port=35938 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0TPy-0001L8-5M for grub-devel@gnu.org; Sun, 03 May 2009 00:35:10 -0400 Received: from c60.cesmail.net ([216.154.195.49]:57142) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M0TPx-00087d-Qs for grub-devel@gnu.org; Sun, 03 May 2009 00:35:09 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 03 May 2009 00:35:09 -0400 Received: from [192.168.1.104] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id B961934C6D for ; Sun, 3 May 2009 00:33:44 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090502111547.GA28211@thorin> References: <20090502111547.GA28211@thorin> Content-Type: text/plain Date: Sun, 03 May 2009 00:35:08 -0400 Message-Id: <1241325308.8745.39.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] improve error messages in grub-setup X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2009 04:35:16 -0000 On Sat, 2009-05-02 at 13:15 +0200, Robert Millan wrote: > This patch improves error messages in grub-setup, and adds a few > warnings when requested to install in odd layouts. > > Since there was no facility to emmit a warning that is always > visible (regardless of verbosity), but doesn't abort execution, > I added one (grub_util_warn ()). Is everyone fine with using > this interface? I'm fine with the code, but the warnings are quite serious. I think grub-install should not proceed if there are any warnings unless there is an option to ignore warnings (e.g. --ignore-warnings or --force). -- Regards, Pavel Roskin