From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Code quality
Date: Sun, 03 May 2009 00:53:49 -0400 [thread overview]
Message-ID: <1241326429.8745.45.camel@ct> (raw)
In-Reply-To: <20090502114155.GE28362@thorin>
On Sat, 2009-05-02 at 13:41 +0200, Robert Millan wrote:
> Can we start using -Werror ? If we can't do it globally, at least for
> individual modules. This way we gradually prevent regressions in more
> areas, and (hopefully) at some point get rid of them.
We should fix the warnings first. We have some warnings where we cast a
64-bit address to a 32-bit address without doing any validation.
Turning those warnings into errors increases the risk that somebody will
add casts mindlessly instead of adding sanity checks.
Also, gcc 4.4.0 adds a bunch of warnings about aliasing.
It would be better to make the build less verbose by default to make the
warnings more visible.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2009-05-03 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 22:10 Code quality Pavel Roskin
2009-05-02 11:41 ` Robert Millan
2009-05-03 4:53 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241326429.8745.45.camel@ct \
--to=proski@gnu.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.