From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0eyg-00021q-2P for mharc-grub-devel@gnu.org; Sun, 03 May 2009 12:55:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0eye-00021l-Uw for grub-devel@gnu.org; Sun, 03 May 2009 12:55:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0eya-00021Z-Db for grub-devel@gnu.org; Sun, 03 May 2009 12:55:44 -0400 Received: from [199.232.76.173] (port=36316 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0eya-00021W-5f for grub-devel@gnu.org; Sun, 03 May 2009 12:55:40 -0400 Received: from c60.cesmail.net ([216.154.195.49]:12026) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M0eyZ-0000fF-Px for grub-devel@gnu.org; Sun, 03 May 2009 12:55:39 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 03 May 2009 12:55:38 -0400 Received: from [192.168.1.104] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id B757734C6D for ; Sun, 3 May 2009 12:54:18 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: Content-Type: text/plain Date: Sun, 03 May 2009 12:55:32 -0400 Message-Id: <1241369732.4472.27.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hfs+ uuid X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2009 16:55:45 -0000 On Sun, 2009-05-03 at 12:42 +0200, Vladimir 'phcoder' Serbinenko wrote: > This is a patch to support UUIDs on HFS+. MD5 code is copied from > Michael Gorven's patch which is copied from libgcrypt nearly verbatim. > Thanks for Cris for the info about how xnu expects UUID to be I suggest that you run all new code through GNU indent. Spacing in "32-(n)" will probably need to be fixed manually, as it's a preprocessor directive. Commented out call to to _gcry_burn_stack() should probably be removed. I would prefer that we don't use #undef. Instead, the preprocessor defines should use unique names that never need to be redefined. Setting two environment variables is undocumented. I think rd_string should not be needed. If you need it due to the script engine problems, it's better to fix the script engine. At least please mark that hack as a hack. Perhaps we should consider adding %X support to grub_printf(). I realize that it will increase the core slightly, but if it's just a few bytes, we could accept it. Other modules may use it. Or maybe we could have grub_toupper(), perhaps an inline function? Another thing to consider is whether md5 support should be in a separate file. It would make it possible to reuse md5 for other commands. -- Regards, Pavel Roskin