From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0hfU-0001Tq-WA for mharc-grub-devel@gnu.org; Sun, 03 May 2009 15:48:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0hfT-0001Rj-LF for grub-devel@gnu.org; Sun, 03 May 2009 15:48:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0hfP-0001L4-5U for grub-devel@gnu.org; Sun, 03 May 2009 15:48:07 -0400 Received: from [199.232.76.173] (port=55186 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0hfO-0001Ks-Uh for grub-devel@gnu.org; Sun, 03 May 2009 15:48:02 -0400 Received: from c60.cesmail.net ([216.154.195.49]:49875) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M0hfO-0006nh-Ik for grub-devel@gnu.org; Sun, 03 May 2009 15:48:02 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 03 May 2009 15:48:01 -0400 Received: from [192.168.1.151] (c-69-141-194-35.hsd1.pa.comcast.net [69.141.194.35]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 6852934C6D for ; Sun, 3 May 2009 15:46:42 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <49E3E0FB.1070907@verizon.net> <49E5A91C.3000109@verizon.net> <49E5AA2F.1060305@gmail.com> <1240003243.6449.7.camel@localhost> <49E90CCD.90207@verizon.net> <49E91862.9090103@verizon.net> <1240021094.19677.29.camel@accesodirecto.casa> <1241308934.4290.79.camel@accesodirecto.casa> Content-Type: text/plain Date: Sun, 03 May 2009 15:45:38 -0400 Message-Id: <1241379938.2442.60.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: status grub2 port of grub-legasy map command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 May 2009 19:48:08 -0000 On Sun, 2009-05-03 at 11:17 +0200, Vladimir 'phcoder' Serbinenko wrote: > I would suggest, however, that the return type of > grub_mmap_malign_and_register be changed to void* from char*, > just like > the return type from malloc, because it's the meaningful data > type to > indicate a pointer to generic memory _and_ it automatically > casts to any > pointer type the caller uses (which is the reason it's used in > malloc). > Ok with me. Oppositions from anyone else? Committed. Javier, please remove the unneeded cast. -- Regards, Pavel Roskin