From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M0prC-000367-Aw for mharc-grub-devel@gnu.org; Mon, 04 May 2009 00:32:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M0pr9-00035w-Ql for grub-devel@gnu.org; Mon, 04 May 2009 00:32:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M0pr4-00035D-EJ for grub-devel@gnu.org; Mon, 04 May 2009 00:32:42 -0400 Received: from [199.232.76.173] (port=55076 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M0pr4-00035A-8d for grub-devel@gnu.org; Mon, 04 May 2009 00:32:38 -0400 Received: from c60.cesmail.net ([216.154.195.49]:21286) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M0pr3-00060p-UW for grub-devel@gnu.org; Mon, 04 May 2009 00:32:38 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 04 May 2009 00:32:20 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 3514F34C6D for ; Mon, 4 May 2009 00:31:05 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <49FB60BE.7090806@googlemail.com> References: <49FB60BE.7090806@googlemail.com> Content-Type: text/plain Date: Mon, 04 May 2009 00:32:19 -0400 Message-Id: <1241411539.26483.42.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] prevent duplicated entries due to symlinks X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2009 04:32:44 -0000 On Fri, 2009-05-01 at 22:51 +0200, Andreas Born wrote: > If there's both a symlink and a kernel at which the symlink is pointing > in the list of detected kernels of 10_linux, two entries are created for > actually the same kernel. This patch checks for this condition and only > uses the symlink (usually the wanted behaviour), in case the target of > the symlink doesn't exist, it uses neither. > > Furthermore there may be kernel images named e.g. /boot/vmlinuz, so to > detect those the patch doesn't require a hyphen in the kernel name. > In this case the sed used to determine the kernel version, won't return > as expected an empty string. Therefore I replaced it by another one with > the wanted behaviour. > If the kernel version can be empty we don't want to have a "GNU/Linux, > linux " menuentry. Accordingly this patch adds a check for empty kernel > version, so that only "GNU/Linux" will be displayed. The result will be that we would have an entry without version instead of an entry with a version. That's hardly an improvement. Can you give an example where it would be useful? > Finally there's quite a bunch of other names for initrds. This patch > adds support for initrd.gz and initrd.splash. Both initrd.img and > initrd.gz become or were yet supported with two different version > positions and without version at all. For initrd.splash this isn't > needed because it's not kernel version dependent. Please specify where those names are used. Can you give the distribution name and version where such names are used? What is initrd.splash? Why does it need to be handled like initrd and why is it always version independent? Again, where is it used? -- Regards, Pavel Roskin