All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] prevent duplicated entries due to symlinks
Date: Mon, 04 May 2009 17:13:14 -0400	[thread overview]
Message-ID: <1241471594.9047.28.camel@mj> (raw)
In-Reply-To: <49FF1BBE.4090001@googlemail.com>

On Mon, 2009-05-04 at 18:45 +0200, Andreas wrote:
> Pavel Roskin schrieb:
> > The result will be that we would have an entry without version instead
> > of an entry with a version.  That's hardly an improvement.  Can you give
> > an example where it would be useful?
> >   
> You have a symlink named /boot/vmlinuz which points at the current 
> kernel version. Now you could of course find out which kernel version 
> it's pointing at but that version could change anytime.

I see, you want to support loading the "default" kernel, i.e. the one
pointed to by the symlink.  This way, re-running grub-mkconfig won't be
necessary if a new kernel is installed.

>  /boot/vmlinu[zx] 
> and /vmlinu[zx] (there should only exist one of them) are the only cases 
> I can think of which have no version in their name. So you always know 
> that the version-free entry always boots the kernel pointed at by 
> /boot/vmlinuz, which is always the current kernel if your distro 
> maintains the symlink. I see no regression there.

Suppose I have Linux 2.6.29 and 2.6.28.  Your script makes entries for
"Linux default" and "Linux 2.6.28".  Then I install Linux 2.6.30 and
don't run grub-mkconfig.  Then I can boot Linux 2.6.30 and 2.6.28 form
the menu, but not 2.6.29.

Even if I run grub-mkconfig, there is still something I lose.  By
selecting "Linux default" I still don't know it it's Linux 2.6.30 or
something else.

For me, the convenience of not having to rerun grub-mkconfig doesn't
outweigh the convenience of knowing what I'm loading.

I know, it's have to argue about preferences, but if you want you
changes to be accepted, you need to present a good case.

I would consider placing the kernel pointed to by the vmlinuz link to
the first position of the Linux kernels.  Another approach would be to
have an entry for the link without suppressing any versioned entries.

> > Please specify where those names are used.  Can you give the
> > distribution name and version where such names are used?
> >   
> Zenwalk, Slackware for example. I think more Slackware derivates are 
> using it too.

Let's add support for more versioned names first.  That should be rather
non-controversial.

> > What is initrd.splash?  Why does it need to be handled like initrd and
> > why is it always version independent?  Again, where is it used?
> >
> >   
> initrd.splash is used by Zenwalk (others too) it contains only the data 
> of one or multiple bootsplashes as returned by the "splash" command. 
> It's used by bootsplash and doesn't contain any files, modules, etc.
> The version independence is quite self-explaining now, I think. Unless 
> bootsplash support was removed it works for any kernel version. And even 
> if bootsplash support is removed it does no harm to load it.
> 
> Is it understandable now?

It's quite strange that some distro would use the initrd functionality
purely for eye candy.  But if that's true, I'm fine with using
initrd.splash as the last resort if no other initrd image is found.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2009-05-04 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01 20:51 [PATCH] prevent duplicated entries due to symlinks Andreas Born
2009-05-04  4:32 ` Pavel Roskin
2009-05-04 16:45   ` Andreas
2009-05-04 21:13     ` Pavel Roskin [this message]
2009-05-05 21:11       ` Andreas Born
2009-05-09 22:20         ` Andreas
2009-08-18 18:01           ` Pavel Roskin
2009-08-18 19:19     ` Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1241471594.9047.28.camel@mj \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.