From: vibisreenivasan <vibi_sreenivasan@cms.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free
Date: Wed, 06 May 2009 12:51:41 +0530 [thread overview]
Message-ID: <1241594501.2186.0.camel@system> (raw)
In-Reply-To: <4A003612.4010405@redhat.com>
hi Gred,
Thanks for pointing that out.
I will update patch & send it again.
regards
vibi
On Tue, 2009-05-05 at 14:50 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > - path = malloc(len+1);
> > + path = qemu_malloc(len+1);
> > snprintf(path, len+1, "%.*s", len, str);
> > } else
> > path = strdup(str);
>
> You need s/strdup/qemu_strdup/ here (and maybe elsewhere too), otherwise
> you'll mix strdup + qemu_free().
>
> cheers,
> Gerd
>
>
next prev parent reply other threads:[~2009-05-06 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 10:31 [Qemu-devel] [PATCH]:Use qemu_malloc & qemu_free instead of malloc & free vibisreenivasan
2009-05-05 12:50 ` Gerd Hoffmann
2009-05-06 7:21 ` vibisreenivasan [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-05 10:09 [Qemu-devel] [PATCH] Use " vibisreenivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241594501.2186.0.camel@system \
--to=vibi_sreenivasan@cms.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.