Re: [PATCH 2/5] introduce "struct wait_opts" to simplify do_wait() pathes

[Richard Kennedy <richard@rsk.demon.co.uk>]

On Sat, 2009-05-09 at 18:19 +0200, Oleg Nesterov wrote:
> sorry for delay Richard,
> 
> On 05/07, Richard Kennedy wrote:
> >
> > Oleg Nesterov wrote:
> > >
> > > +struct wait_opts {
> > > +	enum pid_type		wo_type;
> > > +	struct pid		*wo_pid;
> > > +	int			wo_flags;
> > > +
> > > +	struct siginfo __user	*wo_info;
> > > +	int __user		*wo_stat;
> > > +	struct rusage __user	*wo_rusage;
> > > +
> > > +	int			notask_error;
> > > +};
> > > +
> >
> > Hi Oleg,
> > you can remove 8 bytes of alignment padding from wait_opts on 64bit
> > builds if you reorder it slightly.
> >
> > struct wait_opts {
> > 	enum pid_type 	wo_type;
> > 	int 		wo_flags;
> > 	struct pid	*wo_pid;
> > 	...
> 
> Thanks, didn't think about this...
> 
> This is already in -mm, perhaps you can send the patch to Andrew?
> 
> Oleg.
> 
no problem. I'll send Andrew a patch shortly.

Richard