From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 4/6] mktree: do not barf on a submodule commit
Date: Sun, 10 May 2009 11:49:49 -0700 [thread overview]
Message-ID: <1241981391-19639-5-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1241981391-19639-4-git-send-email-gitster@pobox.com>
It is perfectly normal if a tree entry points at a missing commit as long
as the mode of the entry says it is a submodule.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
builtin-mktree.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/builtin-mktree.c b/builtin-mktree.c
index 133ab4b..17cdb3d 100644
--- a/builtin-mktree.c
+++ b/builtin-mktree.c
@@ -89,9 +89,16 @@ static void mktree_line(char *buf, size_t len, int line_termination)
ntr[41] != '\t' ||
get_sha1_hex(ntr + 1, sha1))
die("input format error: %s", buf);
- type = sha1_object_info(sha1, NULL);
+
+ /* It is perfectly normal if we do not have a commit from a submodule */
+ if (!S_ISGITLINK(mode))
+ type = sha1_object_info(sha1, NULL);
+ else
+ type = OBJ_COMMIT;
+
if (type < 0)
die("object %s unavailable", sha1_to_hex(sha1));
+
*ntr++ = 0; /* now at the beginning of SHA1 */
if (type != type_from_string(ptr))
die("object type %s mismatch (%s)", ptr, typename(type));
--
1.6.3.9.g6345d
next prev parent reply other threads:[~2009-05-10 18:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-10 13:41 questions about git-mktree Jon Seymour
2009-05-10 15:12 ` Uwe Kleine-König
2009-05-10 15:27 ` A Large Angry SCM
2009-05-10 15:31 ` Jakub Narebski
2009-05-10 16:39 ` Junio C Hamano
2009-05-10 17:10 ` Junio C Hamano
2009-05-10 18:49 ` [PATCH 0/6] Modernize mktree somewhat Junio C Hamano
2009-05-10 18:49 ` [PATCH 1/6] build-in git-mktree Junio C Hamano
2009-05-10 18:49 ` [PATCH 2/6] mktree: use parse-options Junio C Hamano
2009-05-10 18:49 ` [PATCH 3/6] builtin-mktree.c: use a helper function to handle one line of input Junio C Hamano
2009-05-10 18:49 ` Junio C Hamano [this message]
2009-05-10 18:49 ` [PATCH 5/6] t1010: add mktree test Junio C Hamano
2009-05-10 18:49 ` [PATCH 6/6] mktree --missing: allow missing objects Junio C Hamano
2009-05-10 22:13 ` René Scharfe
2009-05-11 0:29 ` Junio C Hamano
2009-05-10 18:54 ` questions about git-mktree - [PATCH] proposed '--batch' option Josh Micich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1241981391-19639-5-git-send-email-gitster@pobox.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.