From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1M4Q7D-0001r9-Tw for mharc-grub-devel@gnu.org; Wed, 13 May 2009 21:52:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M4Q7B-0001qy-RE for grub-devel@gnu.org; Wed, 13 May 2009 21:52:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M4Q77-0001qK-UJ for grub-devel@gnu.org; Wed, 13 May 2009 21:52:05 -0400 Received: from [199.232.76.173] (port=38319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M4Q77-0001qH-RV for grub-devel@gnu.org; Wed, 13 May 2009 21:52:01 -0400 Received: from c60.cesmail.net ([216.154.195.49]:28860) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1M4Q77-00080H-Fy for grub-devel@gnu.org; Wed, 13 May 2009 21:52:01 -0400 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 13 May 2009 21:52:00 -0400 Received: from [192.168.0.22] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 03B2C34C6A for ; Wed, 13 May 2009 21:52:13 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1241883761.22837.97.camel@accesodirecto.casa> References: <49E3E0FB.1070907@verizon.net> <1240021094.19677.29.camel@accesodirecto.casa> <1241308934.4290.79.camel@accesodirecto.casa> <1241384352.2442.133.camel@ct> <1241393832.6586.35.camel@accesodirecto.casa> <1241409431.26483.33.camel@mj> <1241635288.4535.6.camel@accesodirecto.casa> <1241875621.22837.24.camel@accesodirecto.casa> <1241883761.22837.97.camel@accesodirecto.casa> Content-Type: text/plain; charset="ISO-8859-1" Date: Wed, 13 May 2009 21:51:58 -0400 Message-Id: <1242265918.21129.27.camel@mj> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 (2.26.1-2.fc11) Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: status grub2 port of grub-legasy map command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2009 01:52:06 -0000 On Sat, 2009-05-09 at 17:42 +0200, Javier Martín wrote: > OK, I have a good feeling about this version of the patch. Most > importantly, it still works!! I have committed your patch after a cleanup. My changes were following: grub_drivemap_int13_handler_base and grub_drivemap_int13_handler have been merged. grub_drivemap_int13_oldhandler points directly to the ljmp argument (other GRUB sources do it too, jump look for 0xea). %si is not used anymore. Tabs are used consistently in drivemap_int13h.S Many variables have been renamed. Constants have been brought to the top level and marked as such. Logic in uninstall_int13_handler() has been fixed. Some messages have been clarified. In particularly, biosdisk is called osdisk now, as it's what the OS sees. I was thinking of "payload" or "loadee" as more generic terms, but it can be confusing to the users. My check for drivemap with no arguments was wrong, fixed now. Added missing line ends in all outputs. Removed INT13H_REBASE and INT13H_TONEWADDR, as they were used only once. Comments have been improved. -- Regards, Pavel Roskin