From: Phil Carmody <ext-phil.2.carmody@nokia.com>
To: ext Kevin Hilman <khilman@deeprootsystems.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/2] OMAP3: PM: More pedantic parameter and error checking in smartreflex
Date: Thu, 14 May 2009 11:03:59 +0300 [thread overview]
Message-ID: <1242288239.9103.123.camel@pcarmody-desktop> (raw)
In-Reply-To: <87ab5h6j06.fsf@deeprootsystems.com>
On Wed, 2009-05-13 at 18:54 +0200, ext Kevin Hilman wrote:
> Phil Carmody <ext-phil.2.carmody@nokia.com> writes:
>
> > On Wed, 2009-05-13 at 17:10 +0200, ext Kevin Hilman wrote:
> >> Phil Carmody <ext-phil.2.carmody@nokia.com> writes:
> >>
> >> > A couple of simple patches to improve error handling in smartreflex.
> >> > The first has a practical benefit of avoiding a string-based search
> >> > in situtations where the result wouldn't be needed. The second is
> >> > simple paranoia.
> >>
> >> Thanks, pushing this series today.
> >>
> >> Note that I pushed this on top of Rajendra's patch:
> >> "OMAP3: SR: Fix SR driver to check for omap-pm return values"
> >> and had to resolve a couple of conflicts.
> >>
> >> Could you please sanity check it?
> >
> > Sanity check successful. Many thanks, Kevin.
>
> Hmm, you're too fast for me.
It's the time zone difference!
> Not sure how you tested as I hadn't pushed your changes yet ;)
>
> I just pushed them to my pm branch, but they are not yet sync'd to
> tony's tree. Can you try now.
Freshly pulled, indeed I now see the extent of the rework. I don't know
whether -ENODEV or -EINVAL is better, the former just came to mind first
when I was in the file.
Either way, it looks fine. Thanks again.
Phil
prev parent reply other threads:[~2009-05-14 8:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 16:26 [PATCH 0/2] OMAP3: PM: More pedantic parameter and error checking in smartreflex Phil Carmody
2009-04-27 16:26 ` [PATCH 1/2] OMAP3: PM: Don't do unnecessary searches in omap_sr_vdd*_autocomp_store Phil Carmody
2009-04-27 16:26 ` [PATCH 2/2] OMAP3: PM: Early exit on invalid parameters Phil Carmody
2009-05-13 15:10 ` [PATCH 0/2] OMAP3: PM: More pedantic parameter and error checking in smartreflex Kevin Hilman
2009-05-13 15:36 ` Phil Carmody
2009-05-13 16:54 ` Kevin Hilman
2009-05-14 8:03 ` Phil Carmody [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1242288239.9103.123.camel@pcarmody-desktop \
--to=ext-phil.2.carmody@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.