All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: "JBeulich@novell.com" <JBeulich@novell.com>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"linux-kernel-owner@vger.kernel.org" 
	<linux-kernel-owner@vger.kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] x86,percpu: fix pageattr handling with remap allocator
Date: Fri, 15 May 2009 18:17:06 -0700	[thread overview]
Message-ID: <1242436626.27006.8623.camel@localhost.localdomain> (raw)
In-Reply-To: <1242305390-21958-1-git-send-email-tj@kernel.org>

On Thu, 2009-05-14 at 05:49 -0700, Tejun Heo wrote:
> Hello,
> 
> Upon ack, please pull from the following git tree.
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git x86-percpu-pageattr
> 
> This patchset fixes subtile bug in pageattr handling when remap percpu
> first chunk allocator is in use and implements percpu_alloc kernel
> parameter so that allocator can be selected from boot prompt.
> 
> This problem was spotted by Jan Beulich.
> 
> The remap allocator allocates a PMD page per cpu, returns whatever is
> unnecessary to the page allocator and remaps the PMD page into vmalloc
> area to construct the first percpu chunk.  This is to take advantage
> of large page mapping.  

Tejun, Can you please educate me why we need to map this first percpu
chunk (which is pre-allocated during boot and is physically contiguous)
into vmalloc area? Perhaps even for the other dynamically allocated
secondary chunks? (as far as I can see, all the chunk allocations seems
to be physically contiguous and later mapped into vmalloc area)..

That should simplify these things quite a bit(atleast for first percpu
chunk). I am missing something obvious I guess.

thanks,
suresh


  parent reply	other threads:[~2009-05-16  1:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 12:49 [GIT PATCH] x86,percpu: fix pageattr handling with remap allocator Tejun Heo
2009-05-14 12:49 ` [PATCH 1/4] x86: prepare setup_pcpu_remap() for pageattr fix Tejun Heo
2009-05-14 12:49 ` [PATCH 2/4] x86: simplify cpa_process_alias() Tejun Heo
2009-05-14 14:16   ` Jan Beulich
2009-05-14 15:37     ` Tejun Heo
2009-05-14 16:20       ` [PATCH UPDATED 2/4] x86: reorganize cpa_process_alias() Tejun Heo
2009-05-14 12:49 ` [PATCH 3/4] x86: fix pageattr handling for remap percpu allocator Tejun Heo
2009-05-14 16:21   ` [PATCH UPDATED " Tejun Heo
2009-05-14 12:49 ` [PATCH 4/4] x86: implement percpu_alloc kernel parameter Tejun Heo
2009-05-14 14:28 ` [GIT PATCH] x86,percpu: fix pageattr handling with remap allocator Jan Beulich
2009-05-14 15:55   ` Tejun Heo
2009-05-15  7:47     ` Jan Beulich
2009-05-15  8:11       ` Tejun Heo
2009-05-15  8:22         ` Jan Beulich
2009-05-15  8:27           ` Tejun Heo
2009-05-14 16:22 ` Tejun Heo
2009-05-15  4:00   ` Tejun Heo
2009-05-15  4:36     ` David Miller
2009-05-15  4:48       ` Tejun Heo
2009-05-16  1:17 ` Suresh Siddha [this message]
2009-05-16 15:16   ` Tejun Heo
2009-05-16 19:09     ` Suresh Siddha
2009-05-17  1:23       ` Tejun Heo
2009-05-18 19:20         ` Suresh Siddha
2009-05-18 19:41           ` H. Peter Anvin
2009-05-18 21:07             ` Suresh Siddha
2009-05-19  1:28               ` Tejun Heo
2009-05-20 23:01                 ` Suresh Siddha
2009-05-21  0:08                   ` Tejun Heo
2009-05-21  0:36                     ` Suresh Siddha
2009-05-21  1:46                       ` Tejun Heo
2009-05-21  1:48                         ` Tejun Heo
2009-05-21 19:10                         ` Suresh Siddha
2009-05-21 23:18                           ` Tejun Heo
2009-05-22  0:55                             ` Suresh Siddha
2009-05-19  9:44 ` Tejun Heo
2009-05-20  7:54   ` Ingo Molnar
2009-05-20  7:57     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1242436626.27006.8623.camel@localhost.localdomain \
    --to=suresh.b.siddha@intel.com \
    --cc=JBeulich@novell.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.